Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Sep 3, 2025

What do these changes do?

ReDoc

  • get_my_profile (GET /me) and list_groups (GET /groups) include groups.support group field in their response if support group exists, otherwise is null

Related issue/s

How to test

Driving test

cd services/web/server
make install-dev
pytest -vv tests/unit/**/test_user*.py

Dev-ops

None

@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 73.01587% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.86%. Comparing base (1a721f8) to head (b241651).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8294      +/-   ##
==========================================
+ Coverage   87.84%   87.86%   +0.01%     
==========================================
  Files        1940     1940              
  Lines       75310    75322      +12     
  Branches     1311     1311              
==========================================
+ Hits        66158    66180      +22     
+ Misses       8757     8747      -10     
  Partials      395      395              
Flag Coverage Δ
integrationtests 64.09% <45.00%> (+0.02%) ⬆️
unittests 86.52% <69.84%> (+0.01%) ⬆️
Components Coverage Δ
pkg_aws_library 93.59% <ø> (ø)
pkg_celery_library 87.37% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.14% <100.00%> (+0.01%) ⬆️
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database 88.02% <ø> (ø)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library 71.13% <ø> (ø)
pkg_settings_library 90.17% <ø> (ø)
pkg_simcore_sdk 84.97% <ø> (ø)
agent 93.53% <ø> (ø)
api_server 91.93% <ø> (ø)
autoscaling 95.77% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 91.08% <ø> (+0.06%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.46% <ø> (ø)
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.61% <ø> (ø)
resource_usage_tracker 92.13% <ø> (ø)
storage 86.57% <ø> (+0.20%) ⬆️
webclient ∅ <ø> (∅)
webserver 88.01% <57.50%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a721f8...b241651. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov self-assigned this Sep 3, 2025
@pcrespov pcrespov added this to the Cheops milestone Sep 3, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2025

🧪 CI Insights

Here's what we observed from your CI run for b241651.

🟢 All jobs passed!

But CI Insights is watching 👀

@pcrespov pcrespov changed the title WIP: ✨ Is8291/me profile info WIP: ✨ Support center: extend response model of get profile endpoint with support group info Sep 3, 2025
@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Sep 3, 2025
@pcrespov pcrespov changed the title WIP: ✨ Support center: extend response model of get profile endpoint with support group info ✨ Support center: extend response model of get profile endpoint with support group info Sep 3, 2025
@pcrespov pcrespov marked this pull request as ready for review September 3, 2025 12:35
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov force-pushed the is8291/me-profile-info branch from 230f817 to 3c2b458 Compare September 3, 2025 14:52
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

groups.support should be there, not for supporters only but for all users (if the support group exists)

@pcrespov
Copy link
Member Author

pcrespov commented Sep 3, 2025

groups.support should be there, not for supporters only but for all users (if the support group exists)

@odeimaiz you are right. I did a mistake. I am fixing it

@pcrespov
Copy link
Member Author

pcrespov commented Sep 3, 2025

@odeimaiz as you can see in the test, the support group is provided even if the user does not belong to it

image
  • if the user belongs to the support group, then it is added as well in the organizations
  • Q: do we reall need the accessRights for the products group?

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot for the effort

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2025

@pcrespov pcrespov merged commit 63eac38 into ITISFoundation:master Sep 4, 2025
93 of 95 checks passed
@pcrespov pcrespov deleted the is8291/me-profile-info branch September 4, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants