-
Notifications
You must be signed in to change notification settings - Fork 32
✨ Support center: extend response model of get profile endpoint with support group info
#8294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support center: extend response model of get profile endpoint with support group info
#8294
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8294 +/- ##
==========================================
+ Coverage 87.84% 87.86% +0.01%
==========================================
Files 1940 1940
Lines 75310 75322 +12
Branches 1311 1311
==========================================
+ Hits 66158 66180 +22
+ Misses 8757 8747 -10
Partials 395 395
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
🧪 CI InsightsHere's what we observed from your CI run for b241651. 🟢 All jobs passed!But CI Insights is watching 👀 |
get profile endpoint with support group info
get profile endpoint with support group infoget profile endpoint with support group info
services/web/server/src/simcore_service_webserver/groups/_groups_repository.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
230f817 to
3c2b458
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
groups.support should be there, not for supporters only but for all users (if the support group exists)
@odeimaiz you are right. I did a mistake. I am fixing it |
|
@odeimaiz as you can see in the test, the support group is provided even if the user does not belong to it
|
…er/groups.py Co-authored-by: Sylvain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks a lot for the effort
packages/models-library/src/models_library/api_schemas_webserver/groups.py
Outdated
Show resolved
Hide resolved
|




What do these changes do?
get_my_profile(GET /me) andlist_groups(GET /groups) includegroups.supportgroup field in their response if support group exists, otherwise isnullRelated issue/s
/meendpoint (get profile) #8291How to test
Driving test
Dev-ops
None