-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 [Frontend] All users know about the Support group #8305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] All users know about the Support group #8305
Conversation
…/osparc-simcore into enh/all-users-get-support-group
…/CardBase.js Co-authored-by: Copilot <[email protected]>
…/osparc-simcore into enh/all-users-get-support-group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables all users to know about the Support group by making support group information accessible to users who are not part of that group. This allows users to see support group information on resources shared with the support group, and enables sharing projects with the support group through the sharing interface.
Key changes:
- Moved support group logic from the Products store to the Groups store for better accessibility
- Added support group as a new collaboration type with its own icon and handling
- Updated all references to use the centralized Groups store methods for support functionality
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
osparc/store/Groups.js |
Added support group property, collaboration types constants, and methods for support group management |
osparc/store/Products.js |
Removed support group methods that were moved to Groups store |
osparc/product/Utils.js |
Removed isSupportEnabled method now handled by Groups store |
osparc/store/Support.js |
Updated to use Groups store for support enablement and user checks |
osparc/support/SupportCenter.js |
Updated to use Groups store for support user verification |
osparc/support/ConversationPage.js |
Updated to use Groups store for support user checks |
osparc/support/Conversation.js |
Updated to use Groups store for support group ID retrieval |
osparc/ui/message/FlashMessageOEC.js |
Updated to use Groups store for support enablement check |
osparc/ui/list/CollaboratorListItem.js |
Updated collaboration type handling to use string constants |
osparc/share/NewCollaboratorsManager.js |
Added support collaboration type to sorting and filtering logic |
osparc/share/Collaborators.js |
Added support group thumbnail handling |
osparc/filter/OrganizationsAndMembers.js |
Updated collaboration type handling and sorting |
osparc/filter/CollaboratorToggleButton.js |
Added support collaboration type case |
osparc/data/model/Group.js |
Added "support" to valid group types |
osparc/dashboard/ResourceContainerManager.js |
Updated collaboration type comparisons |
osparc/dashboard/CardBase.js |
Added support group icon and sharing logic |
osparc/utils/Icons.js |
Updated to use CardBase constants for consistency |
services/static-webserver/client/source/class/osparc/store/Groups.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx.
THOUGHT:
After reviewing your demo, I had a thought:
We could introduce the concept of making an organization discoverable (i.e., public). This would allow anyone to reach out to the owner (e.g., to request membership). What we’re doing now with the support-group is essentially a special case of this, but it could be generalized to any organization.
Discoverable organizations could be listed in a public directory, similar to how research groups like ITIS maintain a GitHub organization. Interested individuals could request to join, and the request would be routed to the owner. Each organization would also have its own profile (potentially with a website, etc.).
…/osparc-simcore into enh/all-users-get-support-group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…/osparc-simcore into enh/all-users-get-support-group
|



What do these changes do?
This PR lets users that are not part of the support group know that there is a visible support group. This was required to be able display the support group information on resources that the user shared with that group.
In the animation, a

usershares the project with Support via the Support Center. Later on this can be unshared via the Sharing view.Related issue/s
get profileendpoint with support group info #8294How to test
Dev-ops