Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 4, 2025

What do these changes do?

This PR lets users that are not part of the support group know that there is a visible support group. This was required to be able display the support group information on resources that the user shared with that group.

In the animation, a user shares the project with Support via the Support Center. Later on this can be unshared via the Sharing view.
ShareWithSupport

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Sep 4, 2025
@odeimaiz odeimaiz added this to the Cheops milestone Sep 4, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 4, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2025

🧪 CI Insights

Here's what we observed from your CI run for 9c8de6e.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@odeimaiz odeimaiz marked this pull request as ready for review September 4, 2025 09:51
@odeimaiz odeimaiz requested a review from Copilot September 4, 2025 09:51

This comment was marked as outdated.

@odeimaiz odeimaiz requested a review from Copilot September 4, 2025 10:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables all users to know about the Support group by making support group information accessible to users who are not part of that group. This allows users to see support group information on resources shared with the support group, and enables sharing projects with the support group through the sharing interface.

Key changes:

  • Moved support group logic from the Products store to the Groups store for better accessibility
  • Added support group as a new collaboration type with its own icon and handling
  • Updated all references to use the centralized Groups store methods for support functionality

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
osparc/store/Groups.js Added support group property, collaboration types constants, and methods for support group management
osparc/store/Products.js Removed support group methods that were moved to Groups store
osparc/product/Utils.js Removed isSupportEnabled method now handled by Groups store
osparc/store/Support.js Updated to use Groups store for support enablement and user checks
osparc/support/SupportCenter.js Updated to use Groups store for support user verification
osparc/support/ConversationPage.js Updated to use Groups store for support user checks
osparc/support/Conversation.js Updated to use Groups store for support group ID retrieval
osparc/ui/message/FlashMessageOEC.js Updated to use Groups store for support enablement check
osparc/ui/list/CollaboratorListItem.js Updated collaboration type handling to use string constants
osparc/share/NewCollaboratorsManager.js Added support collaboration type to sorting and filtering logic
osparc/share/Collaborators.js Added support group thumbnail handling
osparc/filter/OrganizationsAndMembers.js Updated collaboration type handling and sorting
osparc/filter/CollaboratorToggleButton.js Added support collaboration type case
osparc/data/model/Group.js Added "support" to valid group types
osparc/dashboard/ResourceContainerManager.js Updated collaboration type comparisons
osparc/dashboard/CardBase.js Added support group icon and sharing logic
osparc/utils/Icons.js Updated to use CardBase constants for consistency

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx.

THOUGHT:

After reviewing your demo, I had a thought:
We could introduce the concept of making an organization discoverable (i.e., public). This would allow anyone to reach out to the owner (e.g., to request membership). What we’re doing now with the support-group is essentially a special case of this, but it could be generalized to any organization.

Discoverable organizations could be listed in a public directory, similar to how research groups like ITIS maintain a GitHub organization. Interested individuals could request to join, and the request would be routed to the owner. Each organization would also have its own profile (potentially with a website, etc.).

@odeimaiz odeimaiz enabled auto-merge (squash) September 4, 2025 11:24
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2025

@odeimaiz odeimaiz merged commit 920710a into ITISFoundation:master Sep 5, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants