Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 4, 2025

What do these changes do?

This PR adds unique ID attributes to various UI buttons and widgets to enable easier identification during MetaModeling end-to-end testing. The changes focus on setting IDs for buttons related to probes, parameter connections and function creation.

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz added this to the Cheops milestone Sep 4, 2025
@odeimaiz odeimaiz self-assigned this Sep 4, 2025
@odeimaiz odeimaiz requested a review from Copilot September 4, 2025 15:18
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool! thanks

@odeimaiz odeimaiz marked this pull request as ready for review September 4, 2025 15:21
@odeimaiz odeimaiz changed the title E2e/mm ids [Frontend] e2e: IDs for MetaModeling Sep 4, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) e2e Bugs found by or related to the end-2-end testing labels Sep 4, 2025
@odeimaiz odeimaiz enabled auto-merge (squash) September 4, 2025 15:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds unique ID attributes to various UI buttons and widgets to enable easier identification during end-to-end testing. The changes focus on setting programmatic IDs for buttons related to probes, function creation, and parameter connections.

  • Adds ID attributes to probe connection buttons, function creation buttons, and parameter-related UI elements
  • Removes a development platform check for parameter visibility
  • Enhances testability by providing consistent element identification

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
services/static-webserver/client/source/class/osparc/widget/NodeOutputs.js Adds ID to probe connection button
services/static-webserver/client/source/class/osparc/study/CreateFunction.js Adds ID to create function button
services/static-webserver/client/source/class/osparc/form/renderer/PropForm.js Adds IDs to input connection and parameter buttons, removes development platform check
services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js Adds ID to create function page button

@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2025

🧪 CI Insights

Here's what we observed from your CI run for 5a0bc89.

🟢 All jobs passed!

But CI Insights is watching 👀

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2025

@odeimaiz odeimaiz merged commit d224dfa into ITISFoundation:master Sep 5, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) e2e Bugs found by or related to the end-2-end testing t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants