🐛 [Frontend] FIXES: Add nodes #8312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
🧪 CI InsightsHere's what we observed from your CI run for 958e654. 🟢 All jobs passed!But CI Insights is watching 👀 |
…into fixes/add-nodes
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several bugs related to adding parameters and probes to nodes in the frontend. The primary focus is on handling cases where node metadata is not immediately available when creating new nodes.
Key changes:
- Added proper metadata availability checks before accessing node properties
- Moved event listener registration to ensure proper initialization order
- Fixed width settings for parameter nodes
- Added return statements to ensure error propagation in study loading
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| WorkbenchUI.js | Moved edge highlighting event listener registration outside metadata check |
| NodeUI.js | Added metadata checks and deferred initialization for node layout population |
| PropForm.js | Added metadata availability checks before accessing node outputs |
| MainPageHandler.js | Added return statements to ensure proper error propagation |
| Workbench.js | Added deferred initialization pattern for parameter/probe node creation |
| NodeStatus.js | Moved lock state initialization to constructor to avoid timing issues |
services/static-webserver/client/source/class/osparc/workbench/NodeUI.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/workbench/NodeUI.js
Show resolved
Hide resolved
…into fixes/add-nodes
|
sanderegg
approved these changes
Sep 5, 2025
pcrespov
approved these changes
Sep 5, 2025
GitHK
pushed a commit
that referenced
this pull request
Sep 5, 2025
14 tasks
16 tasks
This was referenced Sep 18, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
There were a few nasty bugs found during the testing of adding parameters and probes to a node.
These bugs were introduced in this PR, while this PR fixes several bugs related to adding parameters and probes to nodes in the frontend. The primary focus is on handling cases where node metadata is not immediately available when creating new nodes.
Related issue/s
How to test
Dev-ops