Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 5, 2025

What do these changes do?

This PR enhances the frontend to show the Tags filter only in the Tutorials tab (the tags filter is still available in the enhanced search bar). Furthermore, only those tags present in the tutorials are listed.

This main purpose of this change is to make a cleaner dashboard and use the tags in the tutorials more like categories. In a follow up PR, they could even be presented as categories and not with the tag icon.

Tags

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Sep 5, 2025
@odeimaiz odeimaiz added this to the Cheops milestone Sep 5, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 5, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2025

🧪 CI Insights

Here's what we observed from your CI run for ca048aa.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@odeimaiz odeimaiz changed the title 🎨 [Frontend] Enh/hide tags 🎨 [Frontend] Enh: Show Tags filter only in the Tutorials tab Sep 5, 2025
@odeimaiz odeimaiz requested a review from Copilot September 5, 2025 14:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the frontend to show the Tags filter only in the Tutorials tab, providing a more focused user experience by conditionally displaying tag filtering based on the current view context.

Key changes:

  • Modified tag filter visibility to be context-dependent
  • Refactored filter layout creation to use child controls
  • Added dynamic tag population based on available content

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
services/static-webserver/client/source/class/osparc/data/model/Node.js Refactored auto-connect ports logic into async function with metadata loading handling
services/static-webserver/client/source/class/osparc/dashboard/TutorialBrowser.js Added tag population and visibility control for tags filter in tutorials
services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserFilter.js Refactored filter layout creation using child controls and made tag filtering conditional

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2025

@odeimaiz odeimaiz marked this pull request as ready for review September 5, 2025 14:27
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MUCH better!

I actually think tags should not be used as folders but rather as a filter mechanism that you can combine as TAG1 & TAG2 etc ...
IMO they belong to the filter tab and not in the side as "a folder"

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2025

@odeimaiz odeimaiz enabled auto-merge (squash) September 5, 2025 15:10
@odeimaiz odeimaiz merged commit 278df26 into ITISFoundation:master Sep 5, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants