Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 8, 2025

What do these changes do?

This PR improves the UX for joining projects with assigned wallets by streamlining the process based on user wallet access and informing users about wallet context changes. It also adds safeguards by disabling certain settings when projects are in use.

  • Joining user has access to the current wallet: let them join without showing the study options window. Inform if the context wallet changed
  • Joining user has NO access to the current wallet: inform them the current constraint (one project -> one wallet)

Extra:

  • Disable when project is being used: (the backend should not allow patching these)
    • Billing Settings
    • Services Updates
    • Boot Options

New user joins without showing the study options window (user has access to the wallet):
Join

New user can't join because has no access to the wallet):
CantJoin

Inform wallet was changed:
InformChange

Disable some settings:
DisableSettings

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Sep 8, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2025

🧪 CI Insights

Here's what we observed from your CI run for 4f74574.

🟢 All jobs passed!

But CI Insights is watching 👀

@odeimaiz odeimaiz marked this pull request as ready for review September 8, 2025 13:13
@odeimaiz odeimaiz requested a review from Copilot September 8, 2025 13:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the UX for joining projects with assigned wallets by streamlining the process based on user wallet access and informing users about wallet context changes. It also adds safeguards by disabling certain settings when projects are in use.

  • Automatically joins users to projects when they have wallet access, skipping the study options dialog
  • Provides clear feedback when users cannot join due to wallet access restrictions
  • Disables billing settings, service updates, and boot options when projects are being used

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
osparc/study/Utils.js Refactors state checking methods to reduce code duplication and improve maintainability
osparc/desktop/wallets/WalletsList.js Updates wallet list header text from "Currently in use" to "Preferred"
osparc/desktop/wallets/WalletListItem.js Renames wallet button control from "favourite-button" to "preferred-button"
osparc/dashboard/ResourceDetails.js Adds utility method to disable widgets when projects are in use and applies it to settings tabs
osparc/dashboard/ResourceBrowserBase.js Implements wallet access checking logic and dynamic button text based on project usage state

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2025

@odeimaiz odeimaiz merged commit 245036e into ITISFoundation:master Sep 8, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants