Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 8, 2025

What do these changes do?

In another effort to lower the entry barrier to the platform, this PR hides some tabs (Billing, Services Updates, Boot Options and Permissions (not sure if we should also hide the Conversations?)) in the window that pops up when the users clicks on a Tutorial that has no write access.

LessTabs

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Sep 8, 2025
@odeimaiz odeimaiz added this to the Cheops milestone Sep 8, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 8, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2025

🧪 CI Insights

Here's what we observed from your CI run for 43b6f32.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@odeimaiz odeimaiz requested a review from Copilot September 9, 2025 08:42
@odeimaiz odeimaiz marked this pull request as ready for review September 9, 2025 08:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements access control for study-like resources by hiding certain pages when users don't have write access. The changes focus on adding permission checks to prevent read-only users from accessing pages that require modification permissions.

  • Adds a new isStudyLike utility function to identify resources that need permission checks
  • Removes the Message Templates page from the Platform Organization (PO) Center
  • Implements write access checks for multiple pages in Resource Details (Billing, Permissions, Services Updates, Services Boot Options)

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

File Description
osparc/utils/Resources.js Adds isStudyLike helper function to group study, template, tutorial, and hypertool resources
osparc/po/POCenter.js Removes the Message Templates page functionality
osparc/dashboard/ResourceDetails.js Adds write permission checks to hide pages from read-only users

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2025

@odeimaiz odeimaiz merged commit bbb7767 into ITISFoundation:master Sep 9, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants