Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 12, 2025

What do these changes do?

This PR refactors the user account UI by restructuring the existing UserDetails component into a more modular tabbed interface UserProfile and UserExtras. This will allow us extend this view with information requested by the POs.

Bonus:

  • UI: When danger-button is disabled do not paint it red (it is not dangerous)

UserAccount

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Sep 12, 2025
@odeimaiz odeimaiz added this to the Cheops milestone Sep 12, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 12, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2025

🧪 CI Insights

Here's what we observed from your CI run for 9f45d00.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@odeimaiz odeimaiz changed the title ♻️ [Frontend] Clean-up search by groupId 🎨 [Frontend] Enh: User Account UI Sep 12, 2025
@odeimaiz odeimaiz marked this pull request as ready for review September 12, 2025 08:36
@odeimaiz odeimaiz requested a review from Copilot September 12, 2025 08:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the user account UI by restructuring the existing UserDetails component into a more modular tabbed interface. The main purpose is to enhance the user account display with better organization and separation of concerns.

Key changes:

  • Refactors UserDetails into multiple specialized components (UserAccount, UserProfile, UserExtras, UserAccountWindow)
  • Introduces a tabbed interface for user information display
  • Adds date formatting utility for better data presentation

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
services/static-webserver/client/source/class/osparc/utils/Utils.js Adds isDateLike utility function for date validation
services/static-webserver/client/source/class/osparc/user/UserProfile.js Refactors from UserDetails to focused profile display component
services/static-webserver/client/source/class/osparc/user/UserExtras.js New component for displaying extra user data with date formatting
services/static-webserver/client/source/class/osparc/user/UserAccountWindow.js New window wrapper for the user account interface
services/static-webserver/client/source/class/osparc/user/UserAccount.js New main controller component managing user data and tabs
services/static-webserver/client/source/class/osparc/ui/basic/UserThumbnail.js Updates reference from UserDetails to UserAccountWindow
services/static-webserver/client/source/class/osparc/theme/Appearance.js Adds disabled state styling for danger buttons

@sonarqubecloud
Copy link

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Q: can you select and copy the field values in the GUI? I think that is important.
thx

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz merged commit 19b60cc into ITISFoundation:master Sep 12, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants