Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 17, 2025

What do these changes do?

sometimes the faker generate words like a which cannot be used safely as docker service names...

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Cheops milestone Sep 17, 2025
@sanderegg sanderegg self-assigned this Sep 17, 2025
@sanderegg sanderegg requested a review from pcrespov as a code owner September 17, 2025 09:10
@sanderegg sanderegg added t:maintenance Some planned maintenance work a:models-library 🤖-automerge marks PR as ready to be merged for Mergify labels Sep 17, 2025
@sonarqubecloud
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A maintenance refactor that fixes service name generation by replacing the word-based suffix with a more controlled string generation approach.

  • Changed suffix generation from fake.unique.word() to fake.unique.pystr(min_chars=2) to ensure consistent service name format

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.91%. Comparing base (c6d5810) to head (751f5b7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8377   +/-   ##
=======================================
  Coverage   87.90%   87.91%           
=======================================
  Files        1951     1951           
  Lines       75927    75927           
  Branches     1337     1337           
=======================================
+ Hits        66745    66750    +5     
+ Misses       8783     8778    -5     
  Partials      399      399           
Flag Coverage Δ
integrationtests 63.97% <ø> (+<0.01%) ⬆️
unittests 86.58% <ø> (+<0.01%) ⬆️
Components Coverage Δ
pkg_aws_library 93.59% <ø> (ø)
pkg_celery_library 83.58% <ø> (ø)
pkg_dask_task_models_library 79.33% <ø> (ø)
pkg_models_library 93.09% <ø> (ø)
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database 87.95% <ø> (ø)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library 72.58% <ø> (ø)
pkg_settings_library 90.19% <ø> (ø)
pkg_simcore_sdk 84.99% <ø> (ø)
agent 93.53% <ø> (ø)
api_server 91.93% <ø> (ø)
autoscaling 95.78% <ø> (ø)
catalog 92.36% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 90.98% <ø> (+0.08%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.46% <ø> (ø)
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.62% <ø> (ø)
resource_usage_tracker 92.18% <ø> (-0.22%) ⬇️
storage 86.83% <ø> (+0.16%) ⬆️
webclient ∅ <ø> (∅)
webserver 87.96% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d5810...751f5b7. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2025

queue

🛑 Configuration not compatible with a branch protection setting

The branch protection setting Require branches to be up to date before merging is not compatible with max_parallel_checks>1, queue_conditions != merge_conditions and must be unset.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2025

🧪 CI Insights

Here's what we observed from your CI run for 751f5b7.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@sanderegg sanderegg merged commit 7615106 into ITISFoundation:master Sep 17, 2025
95 checks passed
@sanderegg sanderegg deleted the maintenance/ensure_service_key_always_has_at_least_2_chars branch September 17, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:models-library t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants