Skip to content

🐛Computational backend: fix issue where job_id is inexistent + logs improvements #8395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 19, 2025
Merged

🐛Computational backend: fix issue where job_id is inexistent + logs improvements #8395

merged 5 commits into from
Sep 19, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 19, 2025 •
edited
Loading

What do these changes do?

sometimes the job_id is None and that was not seen during latest refactoring actions.
This PR fixes this and improves logging in some specific locations.
This PR also ensure the comp_pipeline table is in sync when nodes are removed from the graph (revert #2702 in comp_pipelines.py discovered by @matusdrobuliak66 .

Related issue/s

image - relates to https://github.com/ITISFoundation/private-issues/issues/10

How to test

Dev-ops

@sanderegg sanderegg added this to the Cheops milestone Sep 19, 2025
@sanderegg sanderegg self-assigned this Sep 19, 2025
@sanderegg sanderegg requested a review from pcrespov as a code owner September 19, 2025 12:16
@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Sep 19, 2025
@sanderegg sanderegg requested a review from GitHK as a code owner September 19, 2025 12:16
@sanderegg sanderegg added the a:autoscaling autoscaling service in simcore's stack label Sep 19, 2025
wvangeit
wvangeit approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@codecov
Copy link

codecov bot commented Sep 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.22%. Comparing base (0abee9b) to head (52fb016).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (0abee9b) and HEAD (52fb016). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (0abee9b) HEAD (52fb016)
unittests 32 2
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #8395       +/-   ##
===========================================
- Coverage   87.90%   70.22%   -17.68%     
===========================================
  Files        1951      798     -1153     
  Lines       75965    37212    -38753     
  Branches     1336      175     -1161     
===========================================
- Hits        66775    26132    -40643     
- Misses       8790    11023     +2233     
+ Partials      400       57      -343
Flag Coverage Δ
integrationtests 63.94% <87.50%> (-0.04%) ⬇️
unittests 87.12% <94.11%> (+0.55%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.69% <ø> (-8.36%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling 95.78% <100.00%> (ø)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 90.90% <93.75%> (-0.09%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 81.87% <ø> (-8.59%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 58.80% <ø> (-29.17%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0abee9b...52fb016. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 19, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg merged commit 53f823f into ITISFoundation:master Sep 19, 2025
90 of 92 checks passed
@sanderegg sanderegg deleted the computational-backend/bugfix/no-job-id branch September 19, 2025 13:27
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 52fb016.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI integration-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@mrnicegyu11 mrnicegyu11 mentioned this pull request Sep 22, 2025
Open
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 24, 2025
Closed
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wvangeit wvangeit wvangeit approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@sanderegg sanderegg

Labels

a:autoscaling autoscaling service in simcore's stack a:director-v2 issue related with the director-v2 service

Projects

None yet

Milestone

Cheops

Development

Successfully merging this pull request may close these issues.

3 participants

@sanderegg @wvangeit @matusdrobuliak66