✨Dask sidecar: add threads multiplier (⚠️ Devops) #8419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
a:dask-service
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8419 +/- ##
==========================================
+ Coverage 87.89% 87.91% +0.01%
==========================================
Files 1953 1953
Lines 76045 76047 +2
Branches 1341 1341
==========================================
+ Hits 66842 66858 +16
+ Misses 8802 8788 -14
Partials 401 401
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sanderegg
requested review from
GitHK,
YuryHrytsuk,
mrnicegyu11 and
pcrespov
as code owners
🧪 CI InsightsHere's what we observed from your CI run for 784bfe0. 🟢 All jobs passed!But CI Insights is watching 👀 |
sanderegg
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a configurable threads multiplier for Dask workers to optimize thread allocation based on CPU count rather than using fixed values. This allows for better resource utilization, particularly for non-billable scenarios and non-resource-heavy jobs.
- Adds
DASK_NTHREADS_MULTIPLIERenvironment variable with default value of 1 - Implements thread calculation logic in the dask-sidecar boot script
- Updates configuration files and settings across multiple services
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| services/docker-compose.yml | Adds new environment variable to clusters-keeper service |
| services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_dask.py | Adds enhanced error logging for task retrieval failures |
| services/dask-sidecar/docker/boot.sh | Implements core multiplier logic with validation and calculation |
| services/clusters-keeper/tests/unit/conftest.py | Updates test configuration with new environment variable |
| services/clusters-keeper/src/simcore_service_clusters_keeper/utils/clusters.py | Passes multiplier to dask-sidecar environment |
| services/clusters-keeper/src/simcore_service_clusters_keeper/data/docker-compose.yml | Configures multiplier for dask workers and increases CPU limit |
| services/clusters-keeper/src/simcore_service_clusters_keeper/core/settings.py | Defines new setting with validation constraints |
| .env-devel | Sets default development environment value |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
services/clusters-keeper/src/simcore_service_clusters_keeper/core/settings.py
Show resolved
Hide resolved
pcrespov
approved these changes
Sep 25, 2025
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_dask.py
Show resolved
Hide resolved
sanderegg
force-pushed
the
dask-sidecar/add-threads-multiplier
branch
from
4704124 to
784bfe0
Compare
|
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The dask worker is setup to either:
In non-billable scenarii, and when running jobs that are not resource heavy, it makes sense that the number of threads is higher than the number of CPUs. A fixed amount is suboptimal as this will apply the same number on any type of machine. The multiplier is relative to the number of CPUs.
This PR introduces
DASK_NTHREADS_MULTIPLIERfor the dask-sidecar service which is defaulted to 1. The pendantCLUSTERS_KEEPER_DASK_NTHREADS_MULTIPLIERis also added.Related issue/s
How to test
Dev-ops