Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 9, 2025

What do these changes do?

This PR adds support for read/unread conversation states in the frontend. It introduces differentiated behavior between regular users and support members, with filtering capabilities and visual indicators.

  • Refactors conversation models to use inheritance with ConversationSupport and ConversationProject extending base Conversation
  • Adds filter buttons All/Unread
  • Implements conversation sorting by lastMessageAddedAt and visual badges for unread status indication
  • Support button shows a dot if there is an unread conversation

UnreadMessages

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Oct 9, 2025
@odeimaiz odeimaiz added this to the Cheops milestone Oct 9, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Oct 9, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2025

🧪 CI Insights

Here's what we observed from your CI run for dc64e12.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@odeimaiz odeimaiz changed the title 🎨 [Frontend] Support conversations: read/unread, revolved/open and 🎨 [Frontend] Support conversations: read/unread and revolved/open Oct 9, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Support conversations: read/unread and revolved/open 🎨 [Frontend] Support conversations: read/unread and resolved/open Oct 9, 2025
@odeimaiz odeimaiz requested a review from Copilot October 9, 2025 12:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for read/unread and resolved/open conversation states in the frontend support system. It introduces differentiated behavior between regular users and support members, with filtering capabilities and visual indicators.

  • Refactors conversation models to use inheritance with ConversationSupport and ConversationProject extending base Conversation
  • Adds filter buttons (All/Unread for users, All/Open for supporters) and read/resolved state management
  • Implements conversation sorting by modification date and visual badges for status indication

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
osparc/ui/list/ListItem.js Removes subSubtitle property and adds third-column layout support with MAX_ROWS constant
osparc/support/SupportCenter.js Adds automatic read marking when users view conversations
osparc/support/Conversations.js Implements filter buttons, conversation sorting, and state-based visibility
osparc/support/ConversationPage.js Replaces appointment functionality with resolve case feature for supporters
osparc/support/ConversationListItem.js Adds unread/resolved badges and restores subSubtitle handling locally
osparc/support/Conversation.js Updates to use new ConversationSupport model
osparc/study/ConversationPage.js Updates to use new ConversationProject model
osparc/study/Conversation.js Updates to use new ConversationProject model
osparc/store/ConversationsSupport.js Adds API methods for marking conversations as read/resolved
osparc/data/model/ConversationSupport.js New specialized model for support conversations with read/resolved states
osparc/data/model/ConversationProject.js New specialized model for project conversations
osparc/data/model/Conversation.js Refactored as abstract base class with common conversation functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@odeimaiz odeimaiz added this to the Imparable milestone Oct 14, 2025
@odeimaiz odeimaiz requested a review from Copilot October 14, 2025 11:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

services/static-webserver/client/source/class/osparc/support/ConversationListItem.js:1

  • Array index order is incorrect: after sorting messages by date (oldest first), the first message should be at index 0 and the last message should be at the end of the array. The current assignment is backwards.
/* ************************************************************************

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@odeimaiz odeimaiz marked this pull request as ready for review October 14, 2025 13:46
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

@odeimaiz odeimaiz enabled auto-merge (squash) October 14, 2025 13:56
@odeimaiz odeimaiz merged commit 1f07d4a into ITISFoundation:master Oct 14, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants