-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 [Frontend] Show warning message when no personal wallet is found #8563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the codebase to centralize the check for billable product status and adds a warning message when no personal wallet is found. The main change replaces calls to osparc.desktop.credits.Utils.areWalletsEnabled() with osparc.store.StaticInfo.isBillableProduct() throughout the application, and renames wallet/credit fetching methods from reload to fetch for better semantic clarity.
Key Changes
- Introduced
isBillableProduct()method inStaticInfo.jsand deprecatedareWalletsEnabled()fromUtils.js - Added warning message in
fetchWallets()when no personal wallet is detected - Renamed
reloadCreditPrice()andreloadWallets()tofetchCreditPrice()andfetchWallets()for improved naming consistency
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| osparc/store/StaticInfo.js | Added new isBillableProduct() method to centralize payment status check |
| osparc/store/Store.js | Renamed methods to fetchCreditPrice() and fetchWallets(), added personal wallet detection and warning |
| osparc/desktop/credits/Utils.js | Removed deprecated areWalletsEnabled() method |
| Multiple UI files | Updated all references to use isBillableProduct() instead of areWalletsEnabled() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks
🧪 CI InsightsHere's what we observed from your CI run for 3cb1550. ✅ Passed Jobs With Interesting Signals
|
|



What do these changes do?
This PR adds a warning message when no personal wallet is found. This might only happen when the user was added to a product in a hacky way.
No personal wallet found, some functionalities might not work properly. Please contact support.Related issue/s
How to test
Dev-ops