Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 28, 2025

What do these changes do?

This PR adds a warning message when no personal wallet is found. This might only happen when the user was added to a product in a hacky way.

No personal wallet found, some functionalities might not work properly. Please contact support.

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz requested a review from Copilot October 28, 2025 09:25
@odeimaiz odeimaiz self-assigned this Oct 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the codebase to centralize the check for billable product status and adds a warning message when no personal wallet is found. The main change replaces calls to osparc.desktop.credits.Utils.areWalletsEnabled() with osparc.store.StaticInfo.isBillableProduct() throughout the application, and renames wallet/credit fetching methods from reload to fetch for better semantic clarity.

Key Changes

  • Introduced isBillableProduct() method in StaticInfo.js and deprecated areWalletsEnabled() from Utils.js
  • Added warning message in fetchWallets() when no personal wallet is detected
  • Renamed reloadCreditPrice() and reloadWallets() to fetchCreditPrice() and fetchWallets() for improved naming consistency

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

File Description
osparc/store/StaticInfo.js Added new isBillableProduct() method to centralize payment status check
osparc/store/Store.js Renamed methods to fetchCreditPrice() and fetchWallets(), added personal wallet detection and warning
osparc/desktop/credits/Utils.js Removed deprecated areWalletsEnabled() method
Multiple UI files Updated all references to use isBillableProduct() instead of areWalletsEnabled()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@odeimaiz odeimaiz added this to the Imparable milestone Oct 28, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Oct 28, 2025
@odeimaiz odeimaiz enabled auto-merge (squash) October 28, 2025 09:30
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2025

🧪 CI Insights

Here's what we observed from your CI run for 3cb1550.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI integration-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
system-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View

@sonarqubecloud
Copy link

@odeimaiz odeimaiz merged commit ea69b41 into ITISFoundation:master Oct 29, 2025
108 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants