Fix constructor

Author: mtfishman

src/blocksparsearray/blocksparsearray.jl

@@ -171,9 +171,11 @@ function BlockSparseArray{T,N,A}(
   return BlockSparseArray{T,N,A}(undef, (dim1, dim_rest...))
 end
 
-function unchecked_similartype(a, args...)
-  A = Base.promote_op(similar, a, args...)
-  return !isconcretetype(A) ? Array{T,N} : A
+function similartype_unchecked(
+  A::Type{<:AbstractArray{T}}, axt::Type{<:Tuple{Vararg{Any,N}}}
+) where {T,N}
+  A′ = Base.promote_op(similar, A, axt)
+  return !isconcretetype(A′) ? Array{T,N} : A′
 end
 
 function BlockSparseArray{T,N}(
@@ -186,7 +188,7 @@ function BlockSparseArray{T,N}(
   # ```
   # but that doesn't work when `similar` isn't defined or
   # isn't type stable.
-  A = unchecked_similartype(Array{T}, axt)
+  A = similartype_unchecked(Array{T}, axt)
   return BlockSparseArray{T,N,A}(undef, axes)
 end
 

test/test_basics.jl

@@ -33,6 +33,7 @@ using BlockSparseArrays:
   eachblockstoredindex,
   eachstoredblock,
   eachstoredblockdiagindex,
+  similartype_unchecked,
   sparsemortar,
   view!
 using GPUArraysCore: @allowscalar
@@ -44,6 +45,20 @@ using TestExtras: @constinferred
 using TypeParameterAccessors: TypeParameterAccessors, Position
 include("TestBlockSparseArraysUtils.jl")
 
+@testset "similartype_unchecked" begin
+  @test @constinferred(similartype_unchecked(Array{Float32}, NTuple{2,Int})) ===
+    Matrix{Float32}
+  @test @constinferred(similartype_unchecked(Array{Float32}, NTuple{2,Base.OneTo{Int}})) ===
+    Matrix{Float32}
+  @test @constinferred(similartype_unchecked(AbstractArray{Float32}, NTuple{2,Int})) ===
+    Matrix{Float32}
+  @test @constinferred(similartype_unchecked(JLArray{Float32}, NTuple{2,Int})) ===
+    JLMatrix{Float32}
+  @test @constinferred(
+    similartype_unchecked(JLArray{Float32}, NTuple{2,Base.OneTo{Int}})
+  ) === JLMatrix{Float32}
+end
+
 arrayts = (Array, JLArray)
 @testset "BlockSparseArrays (arraytype=$arrayt, eltype=$elt)" for arrayt in arrayts,
   elt in (Float32, Float64, Complex{Float32}, Complex{Float64})