Skip to content

Commit 25ee61a

Browse files
authored
Apply suggestions from code review
1 parent 81a837f commit 25ee61a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/factorizations/svd.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ true
198198
```
199199
"""
200200
function svd(A; kwargs...)
201-
SVD(svd!(eigencopy_oftype(A, LinearAlgebra.eigtype(eltype(A))); kwargs...))
201+
return SVD(svd!(eigencopy_oftype(A, LinearAlgebra.eigtype(eltype(A))); kwargs...))
202202
end
203203

204204
LinearAlgebra.svdvals(usv::SVD{<:Any,T}) where {T} = (usv.S)::AbstractVector{T}

test/runtests.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ const GROUP = uppercase(
1515

1616
"match files of the form `test_*.jl`, but exclude `*setup*.jl`"
1717
function istestfile(fn)
18-
endswith(fn, ".jl") && startswith(basename(fn), "test_") && !contains(fn, "setup")
18+
return endswith(fn, ".jl") && startswith(basename(fn), "test_") && !contains(fn, "setup")
1919
end
2020
"match files of the form `*.jl`, but exclude `*_notest.jl` and `*setup*.jl`"
2121
function isexamplefile(fn)
22-
endswith(fn, ".jl") && !endswith(fn, "_notest.jl") && !contains(fn, "setup")
22+
return endswith(fn, ".jl") && !endswith(fn, "_notest.jl") && !contains(fn, "setup")
2323
end
2424

2525
@time begin

0 commit comments

Comments
 (0)