Fix printing, start adding tests

Author: mtfishman

src/blocksparsearrayinterface/map.jl

@@ -151,8 +151,12 @@ end
 function map_stored_blocks(f, a::AbstractArray)
   block_stored_indices = collect(eachblockstoredindex(a))
   if isempty(block_stored_indices)
+    eltype_a′ = Base.promote_op(f, eltype(a))
     blocktype_a′ = Base.promote_op(f, blocktype(a))
-    return BlockSparseArray{eltype(blocktype_a′),ndims(a),blocktype_a′}(undef, axes(a))
+    eltype_a′′ = !isconcretetype(eltype_a′) ? Any : eltype_a′
+    blocktype_a′′ =
+      !isconcretetype(blocktype_a′) ? AbstractArray{eltype_a′′,ndims(a)} : blocktype_a′
+    return BlockSparseArray{eltype_a′′,ndims(a),blocktype_a′′}(undef, axes(a))
   end
   stored_blocks = map(B -> f(@view!(a[B])), block_stored_indices)
   blocktype_a′ = eltype(stored_blocks)

test/test_basics.jl

@@ -70,7 +70,7 @@ end
 
 arrayts = (Array, JLArray)
 @testset "BlockSparseArrays (arraytype=$arrayt, eltype=$elt)" for arrayt in arrayts,
-  elt in (Float32, Float64, Complex{Float32}, Complex{Float64})
+  elt in (Float32, Float64, ComplexF32)
 
   dev(a) = adapt(arrayt, a)
   @testset "Broken" begin
@@ -342,6 +342,42 @@ arrayts = (Array, JLArray)
       end
     end
 
+    @testset "Abstract block type" begin
+      a = BlockSparseMatrix{elt,AbstractMatrix{elt}}(undef, [2, 3], [2, 3])
+      @test sprint(show, MIME"text/plain"(), a) isa String
+      @test iszero(storedlength(a))
+      @test iszero(blockstoredlength(a))
+      a[Block(1, 1)] = dev(randn(elt, 2, 2))
+      a[Block(2, 2)] = dev(randn(elt, 3, 3))
+      @test !iszero(a[Block(1, 1)])
+      @test a[Block(1, 1)] isa arrayt{elt,2}
+      @test !iszero(a[Block(2, 2)])
+      @test a[Block(2, 2)] isa arrayt{elt,2}
+      @test iszero(a[Block(2, 1)])
+      @test a[Block(2, 1)] isa Matrix{elt}
+      @test iszero(a[Block(1, 2)])
+      @test a[Block(1, 2)] isa Matrix{elt}
+
+      if arrayt === Array
+        b = copy(a)
+        @test Array(b) ≈ Array(a)
+
+        b = a + a
+        @test Array(b) ≈ Array(a) + Array(a)
+
+        b = 3a
+        @test Array(b) ≈ 3Array(a)
+
+        b = a * a
+        @test Array(b) ≈ Array(a) * Array(a)
+      else
+        @test_broken copy(a)
+        @test_broken a * a
+        @test_broken a + a
+        @test_broken 3a
+      end
+    end
+
     @testset "Transpose" begin
       a = dev(BlockSparseArray{elt}(undef, [2, 2], [3, 3, 1]))
       a[Block(1, 1)] = dev(randn(elt, 2, 3))

test/test_factorizations.jl

@@ -473,3 +473,25 @@ end
   @test sort(diagview(D[Block(1, 1)]); by=abs, rev=true) ≈ D1[1:1]
   @test sort(diagview(D[Block(2, 2)]); by=abs, rev=true) ≈ D2[1:2]
 end
+
+@testset "Abstract block type" begin
+  arrayt = Array
+  elt = Float32
+  dev = adapt(arrayt)
+
+  a = BlockSparseMatrix{elt,AbstractMatrix{elt}}(undef, ([2, 3], [2, 3]))
+  a[Block(1, 1)] = dev(randn(elt, 2, 2))
+  a[Block(2, 2)] = dev(randn(elt, 3, 3))
+  @test_broken eig_full(a)
+  @test_broken eigh_full(a)
+  @test_broken svd_compact(a)
+  @test_broken svd_full(a)
+  @test_broken left_orth(a)
+  @test_broken right_orth(a)
+  @test_broken left_polar(a)
+  @test_broken right_polar(a)
+  @test_broken qr_compact(a)
+  @test_broken qr_full(a)
+  @test_broken lq_compact(a)
+  @test_broken lq_full(a)
+end