Fix check in tensor_product_axis for one-based axes

mtfishman · web-flow · commit 7d4da4b474f1 · 2025-12-03T17:16:38.000-05:00
diff --git a/ext/BlockSparseArraysTensorAlgebraExt/BlockSparseArraysTensorAlgebraExt.jl b/ext/BlockSparseArraysTensorAlgebraExt/BlockSparseArraysTensorAlgebraExt.jl
@@ -10,7 +10,7 @@ using TensorAlgebra: TensorAlgebra, BlockReshapeFusion, BlockedTuple, matricize,
 function TensorAlgebra.tensor_product_axis(
         ::BlockReshapeFusion, r1::BlockUnitRange, r2::BlockUnitRange
     )
-    isone(first(r1)) || isone(first(r2)) ||
+    (isone(first(r1)) && isone(first(r2))) ||
         throw(ArgumentError("Only one-based axes are supported"))
     blockaxpairs = Iterators.product(eachblockaxes1(r1), eachblockaxes1(r2))
     blockaxs = vec(splat(tensor_product_axis).(blockaxpairs))

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ using TensorAlgebra: TensorAlgebra, BlockReshapeFusion, BlockedTuple, matricize,`
`10`	`10`	`function TensorAlgebra.tensor_product_axis(`
`11`	`11`	`::BlockReshapeFusion, r1::BlockUnitRange, r2::BlockUnitRange`
`12`	`12`	`)`
`13`		`- isone(first(r1)) \|\| isone(first(r2)) \|\|`
	`13`	`+ (isone(first(r1)) && isone(first(r2))) \|\|`
`14`	`14`	`throw(ArgumentError("Only one-based axes are supported"))`
`15`	`15`	`blockaxpairs = Iterators.product(eachblockaxes1(r1), eachblockaxes1(r2))`
`16`	`16`	`blockaxs = vec(splat(tensor_product_axis).(blockaxpairs))`