File tree Expand file tree Collapse file tree 4 files changed +9
-0
lines changed Expand file tree Collapse file tree 4 files changed +9
-0
lines changed Original file line number Diff line number Diff line change @@ -107,6 +107,7 @@ for f in [:eig_full!, :eigh_full!]
107
107
D[bI] = bD
108
108
V[bI] = bV
109
109
else
110
+ # TODO : this should be `V[bI] = LinearAlgebra.I`
110
111
copyto! (@view! (V[bI]), LinearAlgebra. I)
111
112
end
112
113
end
Original file line number Diff line number Diff line change @@ -108,6 +108,7 @@ function MatrixAlgebraKit.lq_compact!(
108
108
L[bI] = bL
109
109
Q[bI] = bQ
110
110
else
111
+ # TODO : this should be `Q[bI] = LinearAlgebra.I`
111
112
copyto! (@view! (Q[bI]), LinearAlgebra. I)
112
113
end
113
114
end
@@ -139,6 +140,7 @@ function MatrixAlgebraKit.lq_full!(
139
140
L[bI] = bL
140
141
Q[bI] = bQ
141
142
else
143
+ # TODO : this should be `Q[bI] = LinearAlgebra.I`
142
144
copyto! (@view! (Q[bI]), LinearAlgebra. I)
143
145
end
144
146
end
Original file line number Diff line number Diff line change @@ -110,6 +110,7 @@ function MatrixAlgebraKit.qr_compact!(
110
110
Q[bI] = bQ
111
111
R[bI] = bR
112
112
else
113
+ # TODO : this should be `Q[bI] = LinearAlgebra.I`
113
114
copyto! (@view! (Q[bI]), LinearAlgebra. I)
114
115
end
115
116
end
@@ -142,6 +143,7 @@ function MatrixAlgebraKit.qr_full!(
142
143
Q[bI] = bQ
143
144
R[bI] = bR
144
145
else
146
+ # TODO : this should be `Q[bI] = LinearAlgebra.I`
145
147
copyto! (@view! (Q[bI]), LinearAlgebra. I)
146
148
end
147
149
end
Original file line number Diff line number Diff line change @@ -168,6 +168,7 @@ function MatrixAlgebraKit.svd_compact!(
168
168
S[bI] = bS
169
169
Vᴴ[bI] = bVᴴ
170
170
else
171
+ # TODO : this should be `U[bI] = LinearAlgebra.I` and `Vᴴ[bI] = LinearAlgebra.I`
171
172
copyto! (@view! (U[bI]), LinearAlgebra. I)
172
173
copyto! (@view! (Vᴴ[bI]), LinearAlgebra. I)
173
174
end
@@ -204,15 +205,18 @@ function MatrixAlgebraKit.svd_full!(
204
205
S[bI] = bS
205
206
Vᴴ[bI] = bVᴴ
206
207
else
208
+ # TODO : this should be `U[bI] = LinearAlgebra.I` and `Vᴴ[bI] = LinearAlgebra.I`
207
209
copyto! (@view! (U[bI]), LinearAlgebra. I)
208
210
copyto! (@view! (Vᴴ[bI]), LinearAlgebra. I)
209
211
end
210
212
end
211
213
212
214
# Complete the unitaries for rectangular inputs
215
+ # TODO : this should be `U[Block(I, I)] = LinearAlgebra.I`
213
216
for I in (blocksize (A, 2 ) + 1 ): blocksize (A, 1 )
214
217
copyto! (@view! (U[Block (I, I)]), LinearAlgebra. I)
215
218
end
219
+ # TODO : this should be `Vᴴ[Block(I, I)] = LinearAlgebra.I`
216
220
for I in (blocksize (A, 1 ) + 1 ): blocksize (A, 2 )
217
221
copyto! (@view! (Vᴴ[Block (I, I)]), LinearAlgebra. I)
218
222
end
You can’t perform that action at this time.
0 commit comments