Skip to content

Commit c2e4227

Browse files
committed
BlockPermutedDiagonalAlgorithm rename
1 parent 6702176 commit c2e4227

File tree

1 file changed

+15
-7
lines changed

1 file changed

+15
-7
lines changed

src/factorizations/svd.jl

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
using MatrixAlgebraKit
22

33
"""
4-
BlockDiagonalAlgorithm(A::MatrixAlgebraKit.AbstractAlgorithm)
4+
BlockPermutedDiagonalAlgorithm(A::MatrixAlgebraKit.AbstractAlgorithm)
55
66
A wrapper for `MatrixAlgebraKit.AbstractAlgorithm` that implements the wrapped algorithm on
77
a block-by-block basis, which is possible if the input matrix is a block-diagonal matrix.
88
"""
9-
struct BlockDiagonalAlgorithm{A<:MatrixAlgebraKit.AbstractAlgorithm} <:
9+
struct BlockPermutedDiagonalAlgorithm{A<:MatrixAlgebraKit.AbstractAlgorithm} <:
1010
MatrixAlgebraKit.AbstractAlgorithm
1111
alg::A
1212
end
@@ -15,7 +15,7 @@ function MatrixAlgebraKit.default_svd_algorithm(A::AbstractBlockSparseMatrix; kw
1515
@assert blocktype(A) <: StridedMatrix{<:LinearAlgebra.BLAS.BlasFloat} "unsupported type:
1616
$(blocktype(A))"
1717
alg = MatrixAlgebraKit.LAPACK_DivideAndConquer(; kwargs...)
18-
return BlockDiagonalAlgorithm(alg)
18+
return BlockPermutedDiagonalAlgorithm(alg)
1919
end
2020

2121
#=
@@ -29,7 +29,9 @@ We should probably discuss which way to go.
2929
=#
3030

3131
function MatrixAlgebraKit.initialize_output(
32-
::typeof(svd_compact!), A::AbstractBlockSparseMatrix, alg::BlockDiagonalAlgorithm
32+
::typeof(svd_compact!),
33+
A::AbstractBlockSparseMatrix,
34+
alg::BlockPermutedDiagonalAlgorithm,
3335
)
3436
bm, bn = blocksize(A)
3537
bmn = min(bm, bn)
@@ -81,7 +83,9 @@ function MatrixAlgebraKit.initialize_output(
8183
end
8284

8385
function MatrixAlgebraKit.initialize_output(
84-
::typeof(svd_full!), A::AbstractBlockSparseMatrix, alg::BlockDiagonalAlgorithm
86+
::typeof(svd_full!),
87+
A::AbstractBlockSparseMatrix,
88+
alg::BlockPermutedDiagonalAlgorithm,
8589
)
8690
bm, bn = blocksize(A)
8791

@@ -174,7 +178,9 @@ function MatrixAlgebraKit.check_input(
174178
end
175179

176180
function MatrixAlgebraKit.svd_compact!(
177-
A::AbstractBlockSparseMatrix, USVᴴ, alg::BlockDiagonalAlgorithm
181+
A::AbstractBlockSparseMatrix,
182+
USVᴴ,
183+
alg::BlockPermutedDiagonalAlgorithm,
178184
)
179185
MatrixAlgebraKit.check_input(svd_compact!, A, USVᴴ)
180186
U, S, Vt = USVᴴ
@@ -202,7 +208,9 @@ function MatrixAlgebraKit.svd_compact!(
202208
end
203209

204210
function MatrixAlgebraKit.svd_full!(
205-
A::AbstractBlockSparseMatrix, USVᴴ, alg::BlockDiagonalAlgorithm
211+
A::AbstractBlockSparseMatrix,
212+
USVᴴ,
213+
alg::BlockPermutedDiagonalAlgorithm,
206214
)
207215
MatrixAlgebraKit.check_input(svd_full!, A, USVᴴ)
208216
U, S, Vt = USVᴴ

0 commit comments

Comments
 (0)