Fix factorizations

Author: mtfishman

src/factorizations/lq.jl

@@ -1,22 +1,25 @@
-using MatrixAlgebraKit: MatrixAlgebraKit, lq_compact!, lq_full!
+using MatrixAlgebraKit: MatrixAlgebraKit, default_lq_algorithm, lq_compact!, lq_full!
 
-# TODO: this is a hardcoded for now to get around this function not being defined in the
-# type domain
-function default_blocksparse_lq_algorithm(A::AbstractMatrix; kwargs...)
+function MatrixAlgebraKit.default_lq_algorithm(A::AbstractBlockSparseMatrix; kwargs...)
+  return default_lq_algorithm(typeof(A); kwargs...)
+end
+function MatrixAlgebraKit.default_lq_algorithm(
+  A::Type{<:AbstractBlockSparseMatrix}; kwargs...
+)
   blocktype(A) <: StridedMatrix{<:LinearAlgebra.BLAS.BlasFloat} ||
     error("unsupported type: $(blocktype(A))")
   alg = MatrixAlgebraKit.LAPACK_HouseholderLQ(; kwargs...)
   return BlockPermutedDiagonalAlgorithm(alg)
 end
 function MatrixAlgebraKit.default_algorithm(
-  ::typeof(lq_compact!), A::AbstractBlockSparseMatrix; kwargs...
+  ::typeof(lq_compact!), A::Type{<:AbstractBlockSparseMatrix}; kwargs...
 )
-  return default_blocksparse_lq_algorithm(A; kwargs...)
+  return default_lq_algorithm(A; kwargs...)
 end
 function MatrixAlgebraKit.default_algorithm(
-  ::typeof(lq_full!), A::AbstractBlockSparseMatrix; kwargs...
+  ::typeof(lq_full!), A::Type{<:AbstractBlockSparseMatrix}; kwargs...
 )
-  return default_blocksparse_lq_algorithm(A; kwargs...)
+  return default_q_algorithm(A; kwargs...)
 end
 
 function similar_output(

src/factorizations/polar.jl

@@ -48,12 +48,22 @@ function MatrixAlgebraKit.right_polar!(A::AbstractBlockSparseMatrix, alg::PolarV
 end
 
 function MatrixAlgebraKit.default_algorithm(
-  ::typeof(left_polar!), a::AbstractBlockSparseMatrix; kwargs...
+  ::typeof(left_polar!), A::AbstractBlockSparseMatrix; kwargs...
 )
-  return PolarViaSVD(default_algorithm(svd_compact!, a; kwargs...))
+  return default_algorithm(left_polar!, typeof(A); kwargs...)
 end
 function MatrixAlgebraKit.default_algorithm(
-  ::typeof(right_polar!), a::AbstractBlockSparseMatrix; kwargs...
+  ::typeof(left_polar!), A::Type{<:AbstractBlockSparseMatrix}; kwargs...
 )
-  return PolarViaSVD(default_algorithm(svd_compact!, a; kwargs...))
+  return PolarViaSVD(default_algorithm(svd_compact!, A; kwargs...))
+end
+function MatrixAlgebraKit.default_algorithm(
+  ::typeof(right_polar!), A::AbstractBlockSparseMatrix; kwargs...
+)
+  return default_algorithm(right_polar!, typeof(A); kwargs...)
+end
+function MatrixAlgebraKit.default_algorithm(
+  ::typeof(right_polar!), A::Type{<:AbstractBlockSparseMatrix}; kwargs...
+)
+  return PolarViaSVD(default_algorithm(svd_compact!, A; kwargs...))
 end

src/factorizations/qr.jl

@@ -1,21 +1,24 @@
 using MatrixAlgebraKit:
   MatrixAlgebraKit, default_qr_algorithm, lq_compact!, lq_full!, qr_compact!, qr_full!
 
-# TODO: this is a hardcoded for now to get around this function not being defined in the
-# type domain
 function MatrixAlgebraKit.default_qr_algorithm(A::AbstractBlockSparseMatrix; kwargs...)
+  return default_qr_algorithm(typeof(A); kwargs...)
+end
+function MatrixAlgebraKit.default_qr_algorithm(
+  A::Type{<:AbstractBlockSparseMatrix}; kwargs...
+)
   blocktype(A) <: StridedMatrix{<:LinearAlgebra.BLAS.BlasFloat} ||
     error("unsupported type: $(blocktype(A))")
   alg = MatrixAlgebraKit.LAPACK_HouseholderQR(; kwargs...)
   return BlockPermutedDiagonalAlgorithm(alg)
 end
 function MatrixAlgebraKit.default_algorithm(
-  ::typeof(qr_compact!), A::AbstractBlockSparseMatrix; kwargs...
+  ::typeof(qr_compact!), A::Type{<:AbstractBlockSparseMatrix}; kwargs...
 )
   return default_qr_algorithm(A; kwargs...)
 end
 function MatrixAlgebraKit.default_algorithm(
-  ::typeof(qr_full!), A::AbstractBlockSparseMatrix; kwargs...
+  ::typeof(qr_full!), A::Type{<:AbstractBlockSparseMatrix}; kwargs...
 )
   return default_qr_algorithm(A; kwargs...)
 end

src/factorizations/svd.jl

@@ -12,6 +12,9 @@ struct BlockPermutedDiagonalAlgorithm{A<:MatrixAlgebraKit.AbstractAlgorithm} <:
   alg::A
 end
 
+function MatrixAlgebraKit.default_svd_algorithm(A::AbstractBlockSparseMatrix; kwargs...)
+  return default_svd_algorithm(typeof(A), kwargs...)
+end
 function MatrixAlgebraKit.default_svd_algorithm(
   A::Type{<:AbstractBlockSparseMatrix}; kwargs...
 )
@@ -25,12 +28,12 @@ function MatrixAlgebraKit.default_svd_algorithm(
 end
 
 function MatrixAlgebraKit.default_algorithm(
-  f::typeof(svd_compact!), A::AbstractBlockSparseMatrix; kwargs...
+  f::typeof(svd_compact!), A::Type{<:AbstractBlockSparseMatrix}; kwargs...
 )
   return default_svd_algorithm(A; kwargs...)
 end
 function MatrixAlgebraKit.default_algorithm(
-  f::typeof(svd_full!), A::AbstractBlockSparseMatrix; kwargs...
+  f::typeof(svd_full!), A::Type{<:AbstractBlockSparseMatrix}; kwargs...
 )
   return default_svd_algorithm(A; kwargs...)
 end