From 9a353d8b1151d2d062f1d83fcc8e68198c145d42 Mon Sep 17 00:00:00 2001 From: CompatHelper Julia Date: Fri, 22 Aug 2025 01:27:34 +0000 Subject: [PATCH 1/5] CompatHelper: bump compat for MatrixAlgebraKit in [weakdeps] to 0.3, (keep existing compat) --- Project.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Project.toml b/Project.toml index 50d3d73..0909e7e 100644 --- a/Project.toml +++ b/Project.toml @@ -1,7 +1,7 @@ name = "DiagonalArrays" uuid = "74fd4be6-21e2-4f6f-823a-4360d37c7a77" authors = ["ITensor developers and contributors"] -version = "0.3.16" +version = "0.3.17" [deps] ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a" @@ -23,6 +23,6 @@ DerivableInterfaces = "0.5.5" FillArrays = "1.13.0" LinearAlgebra = "1.10.0" MapBroadcast = "0.1.10" -MatrixAlgebraKit = "0.2" +MatrixAlgebraKit = "0.2, 0.3" SparseArraysBase = "0.7.2" julia = "1.10" From 1f219bb4cc78edabc8e3f5de16220945f109069c Mon Sep 17 00:00:00 2001 From: Matt Fishman Date: Wed, 3 Sep 2025 12:37:37 -0400 Subject: [PATCH 2/5] Update MatrixAlgebraKit version range --- test/Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/Project.toml b/test/Project.toml index 97d324d..0f9870a 100644 --- a/test/Project.toml +++ b/test/Project.toml @@ -18,7 +18,7 @@ DerivableInterfaces = "0.5" DiagonalArrays = "0.3" FillArrays = "1" LinearAlgebra = "1" -MatrixAlgebraKit = "0.2.5" +MatrixAlgebraKit = "0.2.5, 0.3" SafeTestsets = "0.1" SparseArraysBase = "0.7" StableRNGs = "1" From 5b50a217738d54b6718103d870fb966269a6549a Mon Sep 17 00:00:00 2001 From: Matt Fishman Date: Wed, 3 Sep 2025 13:16:04 -0400 Subject: [PATCH 3/5] Update initialize_output function signature --- .../DiagonalArraysMatrixAlgebraKitExt.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/DiagonalArraysMatrixAlgebraKitExt/DiagonalArraysMatrixAlgebraKitExt.jl b/ext/DiagonalArraysMatrixAlgebraKitExt/DiagonalArraysMatrixAlgebraKitExt.jl index fd90124..793e843 100644 --- a/ext/DiagonalArraysMatrixAlgebraKitExt/DiagonalArraysMatrixAlgebraKitExt.jl +++ b/ext/DiagonalArraysMatrixAlgebraKitExt/DiagonalArraysMatrixAlgebraKitExt.jl @@ -125,7 +125,7 @@ for f in [ ] for Alg in [:ScaledDeltaAlgorithm, :DeltaAlgorithm] @eval begin - function MatrixAlgebraKit.initialize_output(::typeof($f), a, alg::$Alg) + function MatrixAlgebraKit.initialize_output(::typeof($f), a::AbstractMatrix, alg::$Alg) return nothing end end From 4b2ec6a052128f0ae3f4437584537b495cada300 Mon Sep 17 00:00:00 2001 From: Matt Fishman Date: Wed, 3 Sep 2025 13:23:45 -0400 Subject: [PATCH 4/5] Restrict input type to AbstractMatrix in check_input --- .../DiagonalArraysMatrixAlgebraKitExt.jl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ext/DiagonalArraysMatrixAlgebraKitExt/DiagonalArraysMatrixAlgebraKitExt.jl b/ext/DiagonalArraysMatrixAlgebraKitExt/DiagonalArraysMatrixAlgebraKitExt.jl index 793e843..02f02cc 100644 --- a/ext/DiagonalArraysMatrixAlgebraKitExt/DiagonalArraysMatrixAlgebraKitExt.jl +++ b/ext/DiagonalArraysMatrixAlgebraKitExt/DiagonalArraysMatrixAlgebraKitExt.jl @@ -148,13 +148,13 @@ for f in [ :svd_vals!, ] @eval begin - function MatrixAlgebraKit.check_input(::typeof($f), a, F, alg::DeltaAlgorithm) + function MatrixAlgebraKit.check_input(::typeof($f), a::AbstractMatrix, F, alg::DeltaAlgorithm) @assert size(a, 1) == size(a, 2) @assert isdiag(a) @assert all(isone, diagview(a)) return nothing end - function MatrixAlgebraKit.check_input(::typeof($f), a, F, alg::ScaledDeltaAlgorithm) + function MatrixAlgebraKit.check_input(::typeof($f), a::AbstractMatrix, F, alg::ScaledDeltaAlgorithm) @assert size(a, 1) == size(a, 2) @assert isdiag(a) @assert allequal(diagview(a)) @@ -164,13 +164,13 @@ for f in [ end for f in [:eig_full!, :eig_vals!, :eigh_full!, :eigh_vals!] @eval begin - function MatrixAlgebraKit.check_input(::typeof($f), a, F, alg::DeltaAlgorithm) + function MatrixAlgebraKit.check_input(::typeof($f), a::AbstractMatrix, F, alg::DeltaAlgorithm) @assert issquare(a) @assert isdiag(a) @assert all(isone, diagview(a)) return nothing end - function MatrixAlgebraKit.check_input(::typeof($f), a, F, alg::ScaledDeltaAlgorithm) + function MatrixAlgebraKit.check_input(::typeof($f), a::AbstractMatrix, F, alg::ScaledDeltaAlgorithm) @assert issquare(a) @assert isdiag(a) @assert allequal(diagview(a)) From 7121c729b70e2c9e9f6291b21d7820bfaf047f6c Mon Sep 17 00:00:00 2001 From: mtfishman Date: Wed, 3 Sep 2025 13:28:48 -0400 Subject: [PATCH 5/5] Format --- .../DiagonalArraysMatrixAlgebraKitExt.jl | 20 ++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/ext/DiagonalArraysMatrixAlgebraKitExt/DiagonalArraysMatrixAlgebraKitExt.jl b/ext/DiagonalArraysMatrixAlgebraKitExt/DiagonalArraysMatrixAlgebraKitExt.jl index 02f02cc..3f94c39 100644 --- a/ext/DiagonalArraysMatrixAlgebraKitExt/DiagonalArraysMatrixAlgebraKitExt.jl +++ b/ext/DiagonalArraysMatrixAlgebraKitExt/DiagonalArraysMatrixAlgebraKitExt.jl @@ -125,7 +125,9 @@ for f in [ ] for Alg in [:ScaledDeltaAlgorithm, :DeltaAlgorithm] @eval begin - function MatrixAlgebraKit.initialize_output(::typeof($f), a::AbstractMatrix, alg::$Alg) + function MatrixAlgebraKit.initialize_output( + ::typeof($f), a::AbstractMatrix, alg::$Alg + ) return nothing end end @@ -148,13 +150,17 @@ for f in [ :svd_vals!, ] @eval begin - function MatrixAlgebraKit.check_input(::typeof($f), a::AbstractMatrix, F, alg::DeltaAlgorithm) + function MatrixAlgebraKit.check_input( + ::typeof($f), a::AbstractMatrix, F, alg::DeltaAlgorithm + ) @assert size(a, 1) == size(a, 2) @assert isdiag(a) @assert all(isone, diagview(a)) return nothing end - function MatrixAlgebraKit.check_input(::typeof($f), a::AbstractMatrix, F, alg::ScaledDeltaAlgorithm) + function MatrixAlgebraKit.check_input( + ::typeof($f), a::AbstractMatrix, F, alg::ScaledDeltaAlgorithm + ) @assert size(a, 1) == size(a, 2) @assert isdiag(a) @assert allequal(diagview(a)) @@ -164,13 +170,17 @@ for f in [ end for f in [:eig_full!, :eig_vals!, :eigh_full!, :eigh_vals!] @eval begin - function MatrixAlgebraKit.check_input(::typeof($f), a::AbstractMatrix, F, alg::DeltaAlgorithm) + function MatrixAlgebraKit.check_input( + ::typeof($f), a::AbstractMatrix, F, alg::DeltaAlgorithm + ) @assert issquare(a) @assert isdiag(a) @assert all(isone, diagview(a)) return nothing end - function MatrixAlgebraKit.check_input(::typeof($f), a::AbstractMatrix, F, alg::ScaledDeltaAlgorithm) + function MatrixAlgebraKit.check_input( + ::typeof($f), a::AbstractMatrix, F, alg::ScaledDeltaAlgorithm + ) @assert issquare(a) @assert isdiag(a) @assert allequal(diagview(a))