-
Notifications
You must be signed in to change notification settings - Fork 1
Define real and imag
#62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 91.47% 91.52% +0.04%
==========================================
Files 11 11
Lines 575 578 +3
==========================================
+ Hits 526 529 +3
Misses 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checking since I might be misunderstanding this:
There are a couple lines that look to me like you are returning the same object in cases where I would expect this to not be possible. Note that the Base behavior is to return an array with a real eltype as well, therefore it is never possible to have an in-place operation for complex arrays:
julia> A = rand(ComplexF64, 2, 2)
2×2 Matrix{ComplexF64}:
0.374141+0.728543im 0.531899+0.0731709im
0.00277646+0.134685im 0.501756+0.906939im
julia> real(A)
2×2 Matrix{Float64}:
0.374141 0.531899
0.00277646 0.501756
julia> imag(A)
2×2 Matrix{Float64}:
0.728543 0.0731709
0.134685 0.906939
This PR defines
realandimagfor aFusionTensor.The default implementation relies on
Broadcastand errors on some axis convention.