More missing definitions

Author: mtfishman

Project.toml

@@ -12,6 +12,7 @@ MapBroadcast = "ebd9b9da-f48d-417c-9660-449667d60261"
 NamedDimsArrays = "60cbd0c0-df58-4cb7-918c-6f5607b73fde"
 UnallocatedArrays = "43c9e47c-e622-40fb-bf18-a09fc8c466b6"
 UnspecifiedTypes = "42b3faec-625b-4613-8ddc-352bf9672b8d"
+VectorInterface = "409d34a3-91d5-4945-b6ec-7529ddf182d8"
 
 [compat]
 Accessors = "0.1.39"
@@ -22,4 +23,5 @@ MapBroadcast = "0.1.5"
 NamedDimsArrays = "0.3.0"
 UnallocatedArrays = "0.1.1"
 UnspecifiedTypes = "0.1.1"
+VectorInterface = "0.5.0"
 julia = "1.10"

src/ITensorBase.jl

@@ -257,6 +257,9 @@ end
 prime(a::AbstractITensor) = setinds(a, prime.(inds(a)))
 noprime(a::AbstractITensor) = setinds(a, noprime.(inds(a)))
 
+using VectorInterface: VectorInterface, scalartype
+VectorInterface.scalartype(a::AbstractITensor) = scalartype(unallocatable(a))
+
 include("quirks.jl")
 
 end

src/quirks.jl

@@ -1,11 +1,15 @@
 # TODO: Define this properly.
 dag(i::Index) = i
+# TODO: Define this properly.
 dag(a::ITensor) = a
 # TODO: Deprecate.
 dim(i::Index) = dename(length(i))
+# TODO: Deprecate.
 dim(a::AbstractITensor) = unname(length(a))
 # TODO: Define this properly.
 hasqns(i::Index) = false
+# TODO: Define this properly.
+hasqns(i::AbstractITensor) = false
 # TODO: Deprecate.
 itensor(parent::AbstractArray, nameddimsindices) = ITensor(parent, nameddimsindices)
 function itensor(parent::AbstractArray, i1::Index, i_rest::Index...)
@@ -29,9 +33,8 @@ end
 
 using LinearAlgebra: qr, svd
 # TODO: Define this in `MatrixAlgebra.jl`/`TensorAlgebra.jl`.
-function factorize(a::AbstractITensor, args...; tags=TagSet(), maxdim=nothing)
-  if isnothing(maxdim)
-    # `tags` are ignored right now.
+function factorize(a::AbstractITensor, args...; maxdim=nothing, cutoff=nothing, kwargs...)
+  if isnothing(maxdim) && isnothing(cutoff)
     Q, R = qr(a, args...)
     return Q, R
   else