-
Notifications
You must be signed in to change notification settings - Fork 21
Move MPS/MPO docs from ITensors.jl #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 90.11% 90.26% +0.15%
==========================================
Files 54 54
Lines 3581 3575 -6
==========================================
Hits 3227 3227
+ Misses 354 348 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emstoudenmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think it's appropriate to move all of this content here, and we can think later about things like the SiteType or OpSum system and moving some of these docs to a different place in the future for some of those systems.
Yes, that's the most controversial part of this. As part of the rewrite those will be in separate packages anyway, so we can primarily document them as part of that package and then link to and maybe repeat some of that documentation in packages like ITensorMPS.jl and ITensorNetworks.jl. My goal for the rewrite is to make ITensors.jl itself much more minimal and split off more functionality into self-contained packages so I think it will be more obvious where to document things. |
Followup to #118.