Added option for MPO-MPS zipup #97
Open
+46
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Sorry for the delay to move it here. |
Author
|
@mtfishman If I resolve the merge conflicts can this be merged? |
Member
Sure, though I have some review comments. Go ahead and fix the merge conflicts and then I'll do a review. |
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Author
|
@mtfishman up to date and the tests are passing locally so I think it's good for your review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 90.31% 90.33% +0.01%
==========================================
Files 54 54
Lines 3604 3610 +6
==========================================
+ Hits 3255 3261 +6
Misses 349 349
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from ITensor/ITensors.jl#1536