Use RegionScalar not dot

Author: JoeyT1994

src/caches/abstractbeliefpropagationcache.jl

@@ -65,9 +65,6 @@ end
 function region_scalar(bpc::AbstractBeliefPropagationCache, pe::PartitionEdge; kwargs...)
   return not_implemented()
 end
-function message_overlap(bpc::AbstractBeliefPropagationCache, partitionedge; kwargs...)
-  return not_implemented()
-end
 partitions(bpc::AbstractBeliefPropagationCache) = not_implemented()
 PartitionedGraphs.partitionedges(bpc::AbstractBeliefPropagationCache) = not_implemented()
 

src/caches/beliefpropagationcache.jl

@@ -109,19 +109,14 @@ function region_scalar(bp_cache::BeliefPropagationCache, pe::PartitionEdge)
   return contract(ts; sequence)[]
 end
 
-function message_overlap(bpc::BeliefPropagationCache, partitionedge; kwargs...)
-  me, mer = only(message(bpc, partitionedge)), only(message(bpc, reverse(partitionedge)))
-  return dot(me, mer)
-end
-
 function rescale_messages(bp_cache::BeliefPropagationCache, pes::Vector{<:PartitionEdge})
   bp_cache = copy(bp_cache)
   mts = messages(bp_cache)
   for pe in pes
     me, mer = normalize.(mts[pe]), normalize.(mts[reverse(pe)])
     set!(mts, pe, me)
     set!(mts, reverse(pe), mer)
-    n = message_overlap(bp_cache, pe)
+    n = region_scalar(bp_cache, pe)
     if isreal(n)
       me[1] *= sign(n)
       n *= sign(n)