Skip to content

Commit 33b9e28

Browse files
author
Jack Dunham
committed
Rename sweep_solve -> sweep_solve! to obey convention
1 parent 2788057 commit 33b9e28

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

src/solvers/applyexp.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ function applyexp(
9191
]
9292
sweep_iter = SweepIterator(init_prob, kws_array)
9393

94-
converged_prob = sweep_solve(sweep_callback, sweep_iter)
94+
converged_prob = sweep_solve!(sweep_callback, sweep_iter)
9595

9696
return state(converged_prob)
9797
end

src/solvers/eigsolve.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ function eigsolve(operator, init_state; nsweeps, nsites=1, outputlevel=0, sweep_
6464
state=align_indices(init_state), operator=ProjTTN(align_indices(operator))
6565
)
6666
sweep_iter = SweepIterator(init_prob, nsweeps; nsites, outputlevel, sweep_kwargs...)
67-
prob = sweep_solve(sweep_iter)
67+
prob = sweep_solve!(sweep_iter)
6868
return eigenvalue(prob), state(prob)
6969
end
7070

src/solvers/fitting.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ function fit_tensornetwork(
9090
kwargs_array = [(; sweep_kwargs..., extra_sweep_kwargs..., sweep) for sweep in 1:nsweeps]
9191

9292
sweep_iter = SweepIterator(init_prob, kwargs_array)
93-
converged_prob = sweep_solve(sweep_iter)
93+
converged_prob = sweep_solve!(sweep_iter)
9494

9595
return rename_vertices(inv_vertex_map(overlap_network), ket(converged_prob))
9696
end

src/solvers/sweep_solve.jl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ default_sweep_callback(sweep_iterator) = sweep_iterator
44

55
# In this implementation the function `sweep_solve` is essentially just a wrapper around
66
# the iterate interface that allows one to pass callbacks.
7-
function sweep_solve(
7+
function sweep_solve!(
88
sweep_iterator;
99
sweep_callback=default_sweep_callback,
1010
region_callback=default_region_callback,
@@ -21,18 +21,18 @@ end
2121

2222
# I suspect that `sweep_callback` is the more commonly used callback, so allow this to
2323
# be set using the `do` syntax.
24-
function sweep_solve(
24+
function sweep_solve!(
2525
sweep_callback, sweep_iterator; region_callback=default_region_callback
2626
)
27-
return sweep_solve(sweep_iterator; sweep_callback, region_callback)
27+
return sweep_solve!(sweep_iterator; sweep_callback, region_callback)
2828
end
2929

30-
function sweep_solve(
30+
function sweep_solve!(
3131
each_region_iterator::EachRegion; region_callback=default_region_callback
3232
)
33-
return sweep_solve(region_callback, each_region_iterator)
33+
return sweep_solve!(region_callback, each_region_iterator)
3434
end
35-
function sweep_solve(region_callback, each_region_iterator::EachRegion)
35+
function sweep_solve!(region_callback, each_region_iterator::EachRegion)
3636
for _ in each_region_iterator
3737
# I don't think it is obvious what object this particular callback should take,
3838
# but for now be consistant and pass the parent sweep iterator.

0 commit comments

Comments
 (0)