Merge remote-tracking branch 'upstream/main'

Author: JoeyT1994

Project.toml

@@ -1,7 +1,7 @@
 name = "ITensorNetworks"
 uuid = "2919e153-833c-4bdc-8836-1ea460a35fc7"
 authors = ["Matthew Fishman <[email protected]>, Joseph Tindall <[email protected]> and contributors"]
-version = "0.11.23"
+version = "0.11.24"
 
 [deps]
 AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"

src/abstractitensornetwork.jl

@@ -586,38 +586,37 @@ function LinearAlgebra.factorize(tn::AbstractITensorNetwork, edge::Pair; kwargs.
 end
 
 # For ambiguity error; TODO: decide whether to use graph mutating methods when resulting graph is unchanged?
-function gauge_walk(
-  alg::Algorithm, tn::AbstractITensorNetwork, edge::AbstractEdge; kwargs...
+function gauge_edge(
+  alg::Algorithm"orthogonalize", tn::AbstractITensorNetwork, edge::AbstractEdge; kwargs...
 )
-  return gauge_walk(tn, [edge]; kwargs...)
-end
-
-function gauge_walk(alg::Algorithm, tn::AbstractITensorNetwork, edge::Pair; kwargs...)
-  return gauge_walk(alg::Algorithm, tn, edgetype(tn)(edge); kwargs...)
+  # tn = factorize(tn, edge; kwargs...)
+  # # TODO: Implement as `only(common_neighbors(tn, src(edge), dst(edge)))`
+  # new_vertex = only(neighbors(tn, src(edge)) ∩ neighbors(tn, dst(edge)))
+  # return contract(tn, new_vertex => dst(edge))
+  tn = copy(tn)
+  left_inds = uniqueinds(tn, edge)
+  ltags = tags(tn, edge)
+  X, Y = factorize(tn[src(edge)], left_inds; tags=ltags, ortho="left", kwargs...)
+  tn[src(edge)] = X
+  tn[dst(edge)] *= Y
+  return tn
 end
 
 # For ambiguity error; TODO: decide whether to use graph mutating methods when resulting graph is unchanged?
 function gauge_walk(
-  alg::Algorithm"orthogonalize",
-  tn::AbstractITensorNetwork,
-  edges::Vector{<:AbstractEdge};
-  kwargs...,
+  alg::Algorithm, tn::AbstractITensorNetwork, edges::Vector{<:AbstractEdge}; kwargs...
 )
-  # tn = factorize(tn, edge; kwargs...)
-  # # TODO: Implement as `only(common_neighbors(tn, src(edge), dst(edge)))`
-  # new_vertex = only(neighbors(tn, src(edge)) ∩ neighbors(tn, dst(edge)))
-  # return contract(tn, new_vertex => dst(edge))
   tn = copy(tn)
   for edge in edges
-    left_inds = uniqueinds(tn, edge)
-    ltags = tags(tn, edge)
-    X, Y = factorize(tn[src(edge)], left_inds; tags=ltags, ortho="left", kwargs...)
-    tn[src(edge)] = X
-    tn[dst(edge)] *= Y
+    tn = gauge_edge(alg, tn, edge; kwargs...)
   end
   return tn
 end
 
+function gauge_walk(alg::Algorithm, tn::AbstractITensorNetwork, edge::Pair; kwargs...)
+  return gauge_edge(alg::Algorithm, tn, edgetype(tn)(edge); kwargs...)
+end
+
 function gauge_walk(
   alg::Algorithm, tn::AbstractITensorNetwork, edges::Vector{<:Pair}; kwargs...
 )