Use Accessors.@set to simplify some code

Author: emstoudenmire

Project.toml

@@ -5,6 +5,7 @@ version = "0.14.0"
 
 [deps]
 AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"
+Accessors = "7d9f7c33-5ae7-4f3b-8dc6-eff91059b697"
 Combinatorics = "861a8166-3701-5b0c-9a16-15d98fcdc6aa"
 Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
 ConstructionBase = "187b0558-2788-49d3-abe0-74a17ed4e7c9"
@@ -51,6 +52,7 @@ ITensorNetworksTensorOperationsExt = "TensorOperations"
 
 [compat]
 AbstractTrees = "0.4.4"
+Accessors = "0.1.42"
 Adapt = "4"
 Combinatorics = "1"
 Compat = "3, 4"

src/solvers/applyexp.jl

@@ -1,4 +1,5 @@
 using Printf: @printf
+using Accessors: @set
 
 @kwdef mutable struct ApplyExpProblem{State} <: AbstractProblem
   operator
@@ -14,15 +15,9 @@ function current_time(A::ApplyExpProblem)
   return iszero(imag(t)) ? real(t) : t
 end
 
-function set_operator(A::ApplyExpProblem, operator)
-  ApplyExpProblem(operator, A.state, A.current_exponent)
-end
-function set_state(A::ApplyExpProblem, state)
-  ApplyExpProblem(A.operator, state, A.current_exponent)
-end
-function set_current_exponent(A::ApplyExpProblem, current_exponent)
-  ApplyExpProblem(A.operator, A.state, current_exponent)
-end
+set_operator(A::ApplyExpProblem, operator) = (@set A.operator = operator)
+set_state(A::ApplyExpProblem, state) = (@set A.state = state)
+set_current_exponent(A::ApplyExpProblem, exponent) = (@set A.current_exponent = exponent)
 
 function region_plan(A::ApplyExpProblem; nsites, time_step, sweep_kwargs...)
   return applyexp_regions(state(A), time_step; nsites, sweep_kwargs...)

src/solvers/eigsolve.jl

@@ -1,34 +1,27 @@
+using Accessors: @set
 using Printf: @printf
 using ITensors: truncerror
 
 @kwdef mutable struct EigsolveProblem{State,Operator} <: AbstractProblem
   operator::Operator
   state::State
   eigenvalue::Number = Inf
-  max_truncerr::Real = 0.0
+  max_truncerror::Real = 0.0
 end
 
 eigenvalue(E::EigsolveProblem) = E.eigenvalue
 state(E::EigsolveProblem) = E.state
 operator(E::EigsolveProblem) = E.operator
-max_truncerr(E::EigsolveProblem) = E.max_truncerr
+max_truncerror(E::EigsolveProblem) = E.max_truncerror
 
-function set_operator(E::EigsolveProblem, operator)
-  EigsolveProblem(operator, E.state, E.eigenvalue, E.max_truncerr)
-end
-function set_eigenvalue(E::EigsolveProblem, eigenvalue)
-  EigsolveProblem(E.operator, E.state, eigenvalue, E.max_truncerr)
-end
-function set_state(E::EigsolveProblem, state)
-  EigsolveProblem(E.operator, state, E.eigenvalue, E.max_truncerr)
-end
-function set_max_truncerr(E::EigsolveProblem, truncerr)
-  EigsolveProblem(E.operator, E.state, E.eigenvalue, truncerr)
-end
+set_operator(E::EigsolveProblem, operator) = (@set E.operator = operator)
+set_eigenvalue(E::EigsolveProblem, eigenvalue) = (@set E.eigenvalue = eigenvalue)
+set_state(E::EigsolveProblem, state) = (@set E.state = state)
+set_max_truncerror(E::EigsolveProblem, truncerror) = (@set E.max_truncerror = truncerror)
 
 function set_truncation_info(E::EigsolveProblem; spectrum=nothing)
   if !isnothing(spectrum)
-    E = set_max_truncerr(E, max(max_truncerr(E), truncerror(spectrum)))
+    E = set_max_truncerror(E, max(max_truncerror(E), truncerror(spectrum)))
   end
   return E
 end
@@ -60,7 +53,7 @@ function sweep_printer(problem::EigsolveProblem; outputlevel, sweep, nsweeps, kw
     end
     @printf("eigenvalue=%.12f", eigenvalue(problem))
     @printf(" maxlinkdim=%d", maxlinkdim(state(problem)))
-    @printf(" max truncerr=%d", max_truncerr(problem))
+    @printf(" max truncerror=%d", max_truncerror(problem))
     println()
     flush(stdout)
   end

src/solvers/fitting.jl

@@ -1,3 +1,4 @@
+using Accessors: @set
 using Graphs: vertices
 using NamedGraphs: AbstractNamedGraph, NamedEdge
 using NamedGraphs.PartitionedGraphs: partitionedges
@@ -17,12 +18,8 @@ ket_graph(F::FittingProblem) = F.ket_graph
 overlap(F::FittingProblem) = F.overlap
 gauge_region(F::FittingProblem) = F.gauge_region
 
-function set_state(F::FittingProblem, state)
-  FittingProblem(state, F.ket_graph, F.overlap, F.gauge_region)
-end
-function set_overlap(F::FittingProblem, overlap)
-  FittingProblem(F.state, F.ket_graph, overlap, F.gauge_region)
-end
+set_state(F::FittingProblem, state) = (@set F.state = state)
+set_overlap(F::FittingProblem, overlap) = (@set F.overlap = overlap)
 
 function ket(F::FittingProblem)
   ket_vertices = vertices(ket_graph(F))