Skip to content

Commit a58ec92

Browse files
author
Jack Dunham
committed
Make use of @with_kwargs macro make code more concise.
1 parent 0b5314d commit a58ec92

File tree

2 files changed

+5
-30
lines changed

2 files changed

+5
-30
lines changed

src/solvers/iterators.jl

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -99,27 +99,10 @@ function increment!(region_iter::RegionIterator)
9999
return region_iter
100100
end
101101

102-
# Purely for our convenience:
103-
function extract!_kwargs(iter)
104-
f = extract!
105-
kwargs = region_kwargs(f, iter)
106-
return default_kwargs(f, iter; kwargs...)
107-
end
108-
function update!_kwargs(iter, local_state)
109-
f = update!
110-
kwargs = region_kwargs(f, iter)
111-
return default_kwargs(f, iter, local_state; kwargs...)
112-
end
113-
function insert!_kwargs(iter, local_state)
114-
f = insert!
115-
kwargs = region_kwargs(f, iter)
116-
return default_kwargs(f, iter, local_state; kwargs...)
117-
end
118-
119102
function compute!(iter::RegionIterator)
120-
local_state = extract!(iter; extract!_kwargs(iter)...)
121-
local_state = update!(iter, local_state; update!_kwargs(iter, local_state)...)
122-
insert!(iter, local_state; insert!_kwargs(iter, local_state)...)
103+
local_state = @with_defaults extract!(iter; region_kwargs(extract!, iter)...)
104+
local_state = @with_defaults update!(iter, local_state; region_kwargs(update!, iter)...)
105+
@with_defaults insert!(iter, local_state; region_kwargs(insert!, iter)...)
123106

124107
return iter
125108
end

src/solvers/subspace/subspace.jl

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,8 @@ using NDTensors.BackendSelection: Backend, @Backend_str
1010
return local_state
1111
end
1212

13-
subspace_expand!_kwargs = default_kwargs(
14-
subspace_expand!,
15-
backend,
16-
region_iter,
17-
local_state;
18-
region_kwargs(subspace_expand!, region_iter)...,
19-
)
20-
21-
local_state = subspace_expand!(
22-
backend, region_iter, local_state; subspace_expand!_kwargs...
13+
local_state = @with_defaults subspace_expand!(
14+
backend, region_iter, local_state; region_kwargs(subspace_expand!, region_iter)...
2315
)
2416

2517
return local_state

0 commit comments

Comments
 (0)