AbstractBeliefPropagationCache #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into BoundaryMPS
This reverts commit a028422.
Member
|
Thanks @JoeyT1994, I'll take a look. I haven't looked at this code in a while so probably it would be helpful to meet to discuss it. |
mtfishman
reviewed
Mar 14, 2025
Member
|
@JoeyT1994 this looks good to me, can you bump the package version so I can register it after it is merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the
BeliefPropagationCachestructure into an abstract and a concrete type in order to support future, more general, bp caches such as theBoundaryMPSCachewhich can be viewed as aBeliefPropagationCachewith the message tensors endowed with extra virtual indices and more complex update rules.Some functions have been renamed in order to reflect their usage better and the
inner,environmentandscalarfunctionality has been cleaned up so as to immediately support more generalabstractbeliefpropagationcachebased Algorithms without the need to hard-code them, provided certain functionality is supported on the underlying cache.@mtfishman this is the PR: #212 but without the
BoundaryMPSCacheparts implemented (which we discussed some changes to and I will work on). This should make for an easier review. Essentially the changes here are a clean-up of the BP code in order to make the way for this future PR (and other caches) where one wants to useBeliefPropagationCachestructures with differentmessage_updatefunctions etc.