Fix state constructor, include definition of permute

Author: mtfishman

src/ITensors.jl

@@ -10,14 +10,15 @@ using ITensorBase:
   commonind,
   commoninds,
   inds,
+  noprime,
   plev,
   prime,
   tags,
   uniqueind,
   uniqueinds
 
 # Quirks, decide where or if to define.
-using ITensorBase: dag, dim, factorize, hasqns, itensor, onehot
+using ITensorBase: OneITensor, dag, dim, factorize, hasqns, itensor, onehot, order, permute
 
 include("SiteTypes/SiteTypes.jl")
 using .SiteTypes: SiteTypes
@@ -46,14 +47,10 @@ end
 # constructing a set of tags.
 macro ts_str(tags) end
 
-# TODO: Used in `ITensorMPS.jl`, decide where or if to define it.
-struct OneITensor end
-
 # TODO: Used in `ITensors.SiteTypes`, need to define.
 function product end
 
 # TODO: Used in `ITensorMPS.jl`, define in `ITensorBase.jl`.
-function noprime end
 function removetags end
 function replaceprime end
 function replacetags end

src/SiteTypes/sitetype.jl

@@ -609,12 +609,14 @@ function state(s::Index, name::AbstractString; kwargs...)::ITensor
     end
   end
 
-  # Try calling state!(::ITensor,::StateName"Name",::SiteType"Tag",s::Index;kwargs...)
-  T = ITensor(s)
-  for st in stypes
-    state!(T, sname, st, s; kwargs...)
-    !isempty(T) && return T
-  end
+  ## TODO: Bring this back, it is broken right now.
+  ## `isempty` isn't the correct function, it should use `isallocated`.
+  ## # Try calling state!(::ITensor,::StateName"Name",::SiteType"Tag",s::Index;kwargs...)
+  ## T = ITensor(s)
+  ## for st in stypes
+  ##   state!(T, sname, st, s; kwargs...)
+  ##   !isempty(T) && return T
+  ## end
 
   #
   # otherwise try calling a function of the form: