Fix exp check for fermionic ITensors #1664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1664 +/- ##
=======================================
Coverage 81.02% 81.02%
=======================================
Files 59 59
Lines 4638 4638
=======================================
Hits 3758 3758
Misses 880 880 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks good, can you add a test of calling |
|
Good suggestion – just added it |
mtfishman
reviewed
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the check inside the
expfunction so it is restricted to fermionic ITensors (and when the fermion system is on) only.Choosing
LindsandRindsto all have the same arrows within each set may be advisable for most cases, but we decided to allow mixed-arrowexpfor now.This PR also wraps selected tests in generated modules. Previously the
test_qnitensors.jlfile would error if run standalone, due to a missing import.