Fix tests

Author: mtfishman

src/kroneckerarray.jl

@@ -359,7 +359,7 @@ end
 
 # norm(a - b) = norm(a1 ⊗ a2 - b1 ⊗ b2)
 #             = norm((a1 - b1) ⊗ a2 + b1 ⊗ (a2 - b2) + (a1 - b1) ⊗ (a2 - b2))
-function dist(a::AbstractKroneckerArray, b::AbstractKroneckerArray)
+function dist_kronecker(a::AbstractKroneckerArray, b::AbstractKroneckerArray)
     a1, a2 = arg1(a), arg2(a)
     b1, b2 = arg1(b), arg2(b)
     diff1 = a1 - b1
@@ -390,7 +390,7 @@ function Base.isapprox(
     elseif a2 == b2
         norm(a1 - b1) * norm(b2)
     else
-        # This could be defined as `KroneckerArrays.dist(a, b)`, but that might have
+        # This could be defined as `KroneckerArrays.dist_kronecker(a, b)`, but that might have
         # numerical precision issues so for now we just error.
         error(
             "`isapprox` not implemented for KroneckerArrays where both arguments differ. " *

test/test_basics.jl

@@ -241,5 +241,5 @@ elts = (Float32, Float64, ComplexF32, ComplexF64)
     rng = StableRNG(123)
     a = randn(rng, 100, 100) ⊗ randn(rng, 100, 100)
     b = (arg1(a) + 1.0e-1 * randn(rng, size(arg1(a)))) ⊗ (arg2(a) + 1.0e-1 * randn(rng, size(arg2(a))))
-    @test KroneckerArrays.dist(a, b) ≈ norm(collect(a) - collect(b)) rtol = 1.0e-2
+    @test KroneckerArrays.dist_kronecker(a, b) ≈ norm(collect(a) - collect(b)) rtol = 1.0e-2
 end

test/test_matrixalgebrakit.jl

@@ -136,5 +136,7 @@ herm(a) = parent(hermitianpart(a))
 
     a = randn(elt, 2, 2) ⊗ randn(elt, 3, 3)
     s = svd_vals(a)
-    @test s ≈ diag(svd_compact(a)[2])
+    s′ = diag(svd_compact(a)[2])
+    @test arg1(s) ≈ arg1(s′)
+    @test arg2(s) ≈ arg2(s′)
 end