Skip to content

Commit aede4cd

Browse files
committed
Simplify, fix tests
1 parent 35b5aba commit aede4cd

File tree

2 files changed

+9
-34
lines changed

2 files changed

+9
-34
lines changed

ext/KroneckerArraysBlockSparseArraysExt/KroneckerArraysBlockSparseArraysExt.jl

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,15 @@ function block_axes(ax::NTuple{N,AbstractUnitRange{<:Integer}}, I::Block{N}) whe
5757
end
5858

5959
## TODO: Is this needed?
60-
## function Base.getindex(
61-
## a::ZeroBlocks{2,KroneckerMatrix{T,A,B}}, I::Vararg{Int,2}
62-
## ) where {T,A<:AbstractMatrix{T},B<:AbstractMatrix{T}}
63-
## ax_a1 = map(arg1, a.parentaxes)
64-
## a1 = ZeroBlocks{2,A}(ax_a1)[I...]
65-
## ax_a2 = map(arg2, a.parentaxes)
66-
## a2 = ZeroBlocks{2,B}(ax_a2)[I...]
67-
## return a1 ⊗ a2
68-
## end
60+
function Base.getindex(
61+
a::ZeroBlocks{2,KroneckerMatrix{T,A,B}}, I::Vararg{Int,2}
62+
) where {T,A<:AbstractMatrix{T},B<:AbstractMatrix{T}}
63+
ax_a1 = map(arg1, a.parentaxes)
64+
a1 = ZeroBlocks{2,A}(ax_a1)[I...]
65+
ax_a2 = map(arg2, a.parentaxes)
66+
a2 = ZeroBlocks{2,B}(ax_a2)[I...]
67+
return a1 a2
68+
end
6969
function Base.getindex(
7070
a::ZeroBlocks{2,EyeKronecker{T,A,B}}, I::Vararg{Int,2}
7171
) where {T,A<:Eye{T},B<:AbstractMatrix{T}}

src/fillarrays/kroneckerarray.jl

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -108,31 +108,6 @@ function _permutedims!!(dest::Delta, src::Delta, perm)
108108
return dest
109109
end
110110

111-
using DerivableInterfaces: DerivableInterfaces, zero!
112-
function DerivableInterfaces.zero!(a::EyeKronecker)
113-
zero!(a.b)
114-
return a
115-
end
116-
function DerivableInterfaces.zero!(a::KroneckerEye)
117-
zero!(a.a)
118-
return a
119-
end
120-
function DerivableInterfaces.zero!(a::EyeEye)
121-
return throw(ArgumentError("Can't zero out `Eye ⊗ Eye`."))
122-
end
123-
124-
function DerivableInterfaces.zero!(a::DeltaKronecker)
125-
zero!(a.b)
126-
return a
127-
end
128-
function DerivableInterfaces.zero!(a::KroneckerDelta)
129-
zero!(a.a)
130-
return a
131-
end
132-
function DerivableInterfaces.zero!(a::DeltaDelta)
133-
return throw(ArgumentError("Can't zero out `Delta ⊗ Delta`."))
134-
end
135-
136111
using Base.Broadcast:
137112
AbstractArrayStyle, AbstractArrayStyle, BroadcastStyle, Broadcasted, broadcasted
138113

0 commit comments

Comments
 (0)