Skip to content

Commit c21f3ac

Browse files
committed
Switch to using rectangular Eye in tests
1 parent e4f5ab1 commit c21f3ac

File tree

1 file changed

+21
-13
lines changed

1 file changed

+21
-13
lines changed

test/test_blocksparsearrays.jl

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ arrayts = (Array, JLArray)
2323
Block(2, 2) => dev(randn(elt, 3, 3) randn(elt, 3, 3)),
2424
)
2525
a = dev(blocksparse(d, r, r))
26+
@test_broken sprint(show, a)
27+
@test sprint(show, MIME("text/plain"), a) isa String
2628
@test blocktype(a) === valtype(d)
2729
@test a isa BlockSparseMatrix{elt,valtype(d)}
2830
@test a[Block(1, 1)] == dev(d[Block(1, 1)])
@@ -69,29 +71,35 @@ arrayts = (Array, JLArray)
6971
end
7072

7173
@testset "BlockSparseArraysExt, SquareEyeKronecker blocks (arraytype=$arrayt, eltype=$elt)" for arrayt in
72-
(
73-
Array,
74-
),
74+
arrayts,
7575
elt in elts
7676

77+
if arrayt == JLArray
78+
# TODO: Collecting to `Array` is broken for GPU arrays so a lot of tests
79+
# are broken, look into fixing that.
80+
continue
81+
end
82+
7783
dev = adapt(arrayt)
7884
r = blockrange([2 × 2, 3 × 3])
7985
d = Dict(
80-
Block(1, 1) => Eye{elt}(2) randn(elt, 2, 2),
81-
Block(2, 2) => Eye{elt}(3) randn(elt, 3, 3),
86+
Block(1, 1) => Eye{elt}(2, 2) randn(elt, 2, 2),
87+
Block(2, 2) => Eye{elt}(3, 3) randn(elt, 3, 3),
8288
)
8389
a = dev(blocksparse(d, r, r))
84-
@test blocktype(a) === valtype(d)
85-
@test a isa BlockSparseMatrix{elt,valtype(d)}
90+
@test_broken sprint(show, a)
91+
@test sprint(show, MIME("text/plain"), a) isa String
92+
@test_broken blocktype(a) === valtype(d)
93+
@test_broken a isa BlockSparseMatrix{elt,valtype(d)}
8694
@test a[Block(1, 1)] == dev(d[Block(1, 1)])
87-
@test a[Block(1, 1)] isa valtype(d)
95+
@test_broken a[Block(1, 1)] isa valtype(d)
8896
@test a[Block(2, 2)] == dev(d[Block(2, 2)])
89-
@test a[Block(2, 2)] isa valtype(d)
90-
@test_broken iszero(a[Block(2, 1)])
91-
@test_broken a[Block(2, 1)] == dev(zeros(elt, 3, 2) zeros(elt, 3, 2))
97+
@test_broken a[Block(2, 2)] isa valtype(d)
98+
@test iszero(a[Block(2, 1)])
99+
@test a[Block(2, 1)] == dev(zeros(elt, 3, 2) zeros(elt, 3, 2))
92100
@test_broken a[Block(2, 1)] isa valtype(d)
93-
@test_broken iszero(a[Block(1, 2)])
94-
@test_broken a[Block(1, 2)] == dev(zeros(elt, 2, 3) zeros(elt, 2, 3))
101+
@test iszero(a[Block(1, 2)])
102+
@test a[Block(1, 2)] == dev(zeros(elt, 2, 3) zeros(elt, 2, 3))
95103
@test_broken a[Block(1, 2)] isa valtype(d)
96104

97105
b = a * a

0 commit comments

Comments
 (0)