Fix left_orth, right_orth

Author: mtfishman

src/KroneckerArrays.jl

@@ -582,9 +582,11 @@ using MatrixAlgebraKit:
   eigh_full,
   qr_compact,
   qr_full,
+  left_orth,
   left_polar,
   lq_compact,
   lq_full,
+  right_orth,
   right_polar,
   svd_compact,
   svd_full
@@ -728,7 +730,10 @@ const SquareEyeKronecker{T,A<:SquareEye{T},B<:AbstractMatrix{T}} = KroneckerMatr
 const KroneckerSquareEye{T,A<:AbstractMatrix{T},B<:SquareEye{T}} = KroneckerMatrix{T,A,B}
 const SquareEyeSquareEye{T,A<:SquareEye{T},B<:SquareEye{T}} = KroneckerMatrix{T,A,B}
 
-struct SquareEyeAlgorithm <: AbstractAlgorithm end
+struct SquareEyeAlgorithm{KWargs<:NamedTuple} <: AbstractAlgorithm
+  kwargs::KWargs
+end
+SquareEyeAlgorithm(; kwargs...) = SquareEyeAlgorithm((; kwargs...))
 
 # Defined to avoid type piracy.
 _copy_input_squareeye(f::F, a) where {F} = copy_input(f, a)
@@ -739,9 +744,11 @@ for f in [
   :eigh_full,
   :qr_compact,
   :qr_full,
+  :left_orth,
   :left_polar,
   :lq_compact,
   :lq_full,
+  :right_orth,
   :right_polar,
   :svd_compact,
   :svd_full,
@@ -765,8 +772,8 @@ for f in [
 ]
   f′ = Symbol("_", f, "_squareeye")
   @eval begin
-    $f′(a) = $f(a)
-    $f′(a::Type{<:SquareEye}) = SquareEyeAlgorithm()
+    $f′(a; kwargs...) = $f(a; kwargs...)
+    $f′(a::Type{<:SquareEye}; kwargs...) = SquareEyeAlgorithm(; kwargs...)
   end
   for T in [:SquareEyeKronecker, :KroneckerSquareEye, :SquareEyeSquareEye]
     @eval begin
@@ -781,23 +788,29 @@ for f in [
 end
 
 # Defined to avoid type piracy.
+_initialize_output_squareeye(f::F, a) where {F} = initialize_output(f, a)
 _initialize_output_squareeye(f::F, a, alg) where {F} = initialize_output(f, a, alg)
+
 for f in [
   :eig_full!,
   :eigh_full!,
   :qr_compact!,
   :qr_full!,
+  :left_orth!,
   :left_polar!,
   :lq_compact!,
   :lq_full!,
+  :right_orth!,
   :right_polar!,
 ]
   @eval begin
+    _initialize_output_squareeye(::typeof($f), a::SquareEye) = (a, a)
     _initialize_output_squareeye(::typeof($f), a::SquareEye, alg) = (a, a)
   end
 end
 for f in [:svd_compact!, :svd_full!]
   @eval begin
+    _initialize_output_squareeye(::typeof($f), a::SquareEye) = (a, a, a)
     _initialize_output_squareeye(::typeof($f), a::SquareEye, alg) = (a, a, a)
   end
 end
@@ -807,9 +820,11 @@ for f in [
   :eigh_full!,
   :qr_compact!,
   :qr_full!,
+  :left_orth!,
   :left_polar!,
   :lq_compact!,
   :lq_full!,
+  :right_orth!,
   :right_polar!,
   :svd_compact!,
   :svd_full!,
@@ -821,6 +836,10 @@ for f in [
   end
   for T in [:SquareEyeKronecker, :KroneckerSquareEye, :SquareEyeSquareEye]
     @eval begin
+      function MatrixAlgebraKit.initialize_output(::typeof($f), a::$T)
+        return _initialize_output_squareeye($f, a.a) .⊗
+               _initialize_output_squareeye($f, a.b)
+      end
       function MatrixAlgebraKit.initialize_output(
         ::typeof($f), a::$T, alg::KroneckerAlgorithm
       )

test/Project.toml

@@ -7,6 +7,7 @@ MatrixAlgebraKit = "6c742aac-3347-4629-af66-fc926824e5e4"
 SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
 Suppressor = "fd094767-a336-5f1f-9728-57cf17d0bbfb"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
+TestExtras = "5ed8adda-3752-4e41-b88a-e8b09835ee3a"
 
 [compat]
 Aqua = "0.8"
@@ -17,3 +18,4 @@ MatrixAlgebraKit = "0.2"
 SafeTestsets = "0.1"
 Suppressor = "0.2"
 Test = "1.10"
+TestExtras = "0.3"

test/test_matrixalgebrakit.jl

@@ -156,12 +156,7 @@ end
   end
 
   for f in (
-    #=left_orth,=#left_polar,
-    lq_compact,
-    lq_full,
-    qr_compact,
-    qr_full,
-    #=right_orth,=#right_polar,
+    left_orth, left_polar, lq_compact, lq_full, qr_compact, qr_full, right_orth, right_polar
   )
     a = Eye(3) ⊗ randn(3, 3)
     x, y = f(a)