Rewrite broadcasting and mapping to make it simpler and more general #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite broadcasting and mapping to make it simpler and more general. The strategy is to rewrite broadcasting expressions involving KroneckerArrays in terms of an internal Broadcasted-like lazy type called
Sumwhich represents a linear combination of objects (normally arrays but they could themselves be broadcast expressions) with corresponding scalar coefficients.The idea is that because we want to preserve the KroneckerArray structure, as we construct the broadcast expression we catch operations that are linear and build a
Sumexpression for that linear expression. Then, we can make use of that linear structure when materializing the broadcast expression.This also flips the implementation around and implements map in terms of broadcast, which simplifies things a lot.