Skip to content

Conversation

@lkdvos
Copy link
Contributor

@lkdvos lkdvos commented Nov 3, 2025

This is a small PR to fix some issues that were probably caused by upstream function signature changes.
The current main is erroring: https://github.com/ITensor/KroneckerArrays.jl/actions/runs/19049118941
This should resolve this issue.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.87%. Comparing base (e26bcf3) to head (1f87f1c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   81.87%   81.87%           
=======================================
  Files           9        9           
  Lines         618      618           
=======================================
  Hits          506      506           
  Misses        112      112           
Flag Coverage Δ
docs 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos lkdvos changed the title Ld fix Fix some ambiguity issues related to upstream changes Nov 3, 2025
@mtfishman
Copy link
Member

Thanks. As discussed, we should be able to remove some of these definitions thanks to recent improvements to BlockArrays.jl but that's a bigger project which we can do later.

@mtfishman mtfishman merged commit 06d9939 into main Nov 3, 2025
14 checks passed
@mtfishman mtfishman deleted the ld-fix branch November 3, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants