[SparseArraysBase] Rename SparseArrayInterface to SparseArraysBase (#1591)

mtfishman · web-flow · commit 3d2763448eec · 2024-11-15T19:23:57.000-05:00
diff --git a/ext/NamedDimsArraysSparseArrayInterfaceExt/src/NamedDimsArraysSparseArrayInterfaceExt.jl b/ext/NamedDimsArraysSparseArrayInterfaceExt/src/NamedDimsArraysSparseArrayInterfaceExt.jl
diff --git a/ext/NamedDimsArraysSparseArraysBaseExt/src/NamedDimsArraysSparseArraysBaseExt.jl b/ext/NamedDimsArraysSparseArraysBaseExt/src/NamedDimsArraysSparseArraysBaseExt.jl
@@ -0,0 +1,3 @@
+module NamedDimsArraysSparseArraysBaseExt
+include("densearray.jl")
+end
diff --git a/ext/NamedDimsArraysSparseArraysBaseExt/src/densearray.jl b/ext/NamedDimsArraysSparseArraysBaseExt/src/densearray.jl
@@ -1,8 +1,8 @@
 using ..NamedDimsArrays: AbstractNamedDimsArray, dimnames, named, unname
-using ...SparseArrayInterface: SparseArrayInterface, densearray
+using ...SparseArraysBase: SparseArraysBase, densearray
 
 # TODO: Use `Adapt` or some kind of rewrap function like in
 # ArrayInterface.jl (https://github.com/JuliaArrays/ArrayInterface.jl/issues/136)
-function SparseArrayInterface.densearray(na::AbstractNamedDimsArray)
+function SparseArraysBase.densearray(na::AbstractNamedDimsArray)
   return named(densearray(unname(na)), dimnames(na))
 end
diff --git a/ext/NamedDimsArraysSparseArraysBaseExt/test/Project.toml b/ext/NamedDimsArraysSparseArraysBaseExt/test/Project.toml
diff --git a/ext/NamedDimsArraysSparseArraysBaseExt/test/runtests.jl b/ext/NamedDimsArraysSparseArraysBaseExt/test/runtests.jl
@@ -1,10 +1,9 @@
 @eval module $(gensym())
 using LinearAlgebra: Diagonal
 using Test: @test, @testset
-using NDTensors.SparseArrayInterface: densearray
+using NDTensors.SparseArraysBase: densearray
 using NDTensors.NamedDimsArrays: named, unname
-@testset "NamedDimsArraysSparseArrayInterfaceExt (eltype=$elt)" for elt in
-                                                                    (Float32, Float64)
+@testset "NamedDimsArraysSparseArraysBaseExt (eltype=$elt)" for elt in (Float32, Float64)
   na = named(Diagonal(randn(2)), ("i", "j"))
   na_dense = densearray(na)
   @test na ≈ na_dense
diff --git a/src/NamedDimsArrays.jl b/src/NamedDimsArrays.jl
@@ -21,7 +21,7 @@ include("broadcast.jl")
 # Extensions
 include("../ext/NamedDimsArraysAdaptExt/src/NamedDimsArraysAdaptExt.jl")
 include(
-  "../ext/NamedDimsArraysSparseArrayInterfaceExt/src/NamedDimsArraysSparseArrayInterfaceExt.jl",
+  "../ext/NamedDimsArraysSparseArraysBaseExt/src/NamedDimsArraysSparseArraysBaseExt.jl"
 )
 include("../ext/NamedDimsArraysTensorAlgebraExt/src/NamedDimsArraysTensorAlgebraExt.jl")
 end
diff --git a/test/test_NamedDimsArraysSparseArrayInterfaceExt.jl b/test/test_NamedDimsArraysSparseArrayInterfaceExt.jl
@@ -1,5 +1,5 @@
 using Test: @testset
 
 @testset "NamedDimsArrays $(@__FILE__)" begin
-  include("../ext/NamedDimsArraysSparseArrayInterfaceExt/test/runtests.jl")
+  include("../ext/NamedDimsArraysSparseArraysBaseExt/test/runtests.jl")
 end

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+module NamedDimsArraysSparseArraysBaseExt`
	`2`	`+include("densearray.jl")`
	`3`	`+end`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ include("broadcast.jl")`
`21`	`21`	`# Extensions`
`22`	`22`	`include("../ext/NamedDimsArraysAdaptExt/src/NamedDimsArraysAdaptExt.jl")`
`23`	`23`	`include(`
`24`		`- "../ext/NamedDimsArraysSparseArrayInterfaceExt/src/NamedDimsArraysSparseArrayInterfaceExt.jl",`
	`24`	`+ "../ext/NamedDimsArraysSparseArraysBaseExt/src/NamedDimsArraysSparseArraysBaseExt.jl"`
`25`	`25`	`)`
`26`	`26`	`include("../ext/NamedDimsArraysTensorAlgebraExt/src/NamedDimsArraysTensorAlgebraExt.jl")`
`27`	`27`	`end`