Try fixing tests

Author: mtfishman

README.md

@@ -34,6 +34,8 @@ julia> Pkg.add("SparseArraysBase")
 ````julia
 using SparseArraysBase:
   SparseArrayDOK,
+  SparseMatrixDOK,
+  SparseVectorDOK,
   eachstoredindex,
   getstoredindex,
   getunstoredindex,
@@ -62,15 +64,16 @@ a[1, 2] = 12
 SparseArraysBase interface:
 
 ````julia
+using Dictionaries: IndexError
 @test issetequal(eachstoredindex(a), [CartesianIndex(1, 2)])
 @test getstoredindex(a, 1, 2) == 12
-@test_throws KeyError getstoredindex(a, 1, 1)
+@test_throws IndexError getstoredindex(a, 1, 1)
 @test getunstoredindex(a, 1, 1) == 0
 @test getunstoredindex(a, 1, 2) == 0
 @test !isstored(a, 1, 1)
 @test isstored(a, 1, 2)
 @test setstoredindex!(copy(a), 21, 1, 2) == [0 21; 0 0]
-@test_throws KeyError setstoredindex!(copy(a), 21, 2, 1)
+@test_throws IndexError setstoredindex!(copy(a), 21, 2, 1)
 @test setunstoredindex!(copy(a), 21, 1, 2) == [0 21; 0 0]
 @test storedlength(a) == 1
 @test issetequal(storedpairs(a), [CartesianIndex(1, 2) => 12])
@@ -81,11 +84,30 @@ AbstractArray functionality:
 
 ````julia
 b = a .+ 2 .* a'
+@test b isa SparseMatrixDOK{Float64}
 @test b == [0 12; 24 0]
 @test storedlength(b) == 2
-@test b isa SparseArrayDOK{Float64}
 
-a * a'
+b = permutedims(a, (2, 1))
+@test b isa SparseMatrixDOK{Float64}
+@test b[1, 1] == a[1, 1]
+@test b[2, 1] == a[1, 2]
+@test b[1, 2] == a[2, 1]
+@test b[2, 2] == a[2, 2]
+
+b = a * a'
+@test b isa SparseMatrixDOK{Float64}
+@test b == [144 0; 0 0]
+@test storedlength(b) == 1
+````
+
+Second column.
+
+````julia
+b = a[1:2, 2]
+@test b isa SparseVectorDOK{Float64}
+@test b == [12, 0]
+@test storedlength(b) == 1
 ````
 
 ---

src/abstractsparsearrayinterface.jl

@@ -2,13 +2,16 @@
 # TODO: Define default definitions for these based
 # on the dense case.
 # TODO: Define as `MethodError`.
-storedvalues(a) = error()
-isstored(a, I::Int...) = error()
-eachstoredindex(a) = error()
-getstoredindex(a, I::Int...) = error()
-getunstoredindex(a, I::Int...) = error()
-setstoredindex!(a, value, I::Int...) = error()
-setunstoredindex!(a, value, I::Int...) = error()
+## isstored(a::AbstractArray, I::Int...) = true
+isstored(a::AbstractArray, I::Int...) = error("Not implemented.")
+## eachstoredindex(a::AbstractArray) = eachindex(a)
+eachstoredindex(a::AbstractArray) = error("Not implemented.")
+## getstoredindex(a::AbstractArray, I::Int...) = getindex(a, I...)
+getstoredindex(a::AbstractArray, I::Int...) = error("Not implemented.")
+## setstoredindex!(a::AbstractArray, value, I::Int...) = setindex!(a, value, I...)
+setstoredindex!(a::AbstractArray, value, I::Int...) = error("Not implemented.")
+## setunstoredindex!(a::AbstractArray, value, I::Int...) = setindex!(a, value, I...)
+setunstoredindex!(a::AbstractArray, value, I::Int...) = error("Not implemented.")
 
 # TODO: Use `Base.to_indices`?
 isstored(a::AbstractArray, I::CartesianIndex) = isstored(a, Tuple(I)...)
@@ -24,7 +27,7 @@ end
 # Interface defaults.
 # TODO: Have a fallback that handles element types
 # that don't define `zero(::Type)`.
-getunstoredindex(a, I::Int...) = zero(eltype(a))
+getunstoredindex(a::AbstractArray, I::Int...) = zero(eltype(a))
 
 # Derived interface.
 storedlength(a::AbstractArray) = length(storedvalues(a))

test/Project.toml

@@ -1,5 +1,6 @@
 [deps]
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
+Derive = "a07dfc7f-7d04-4eb5-84cc-a97f051f655a"
 SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
 SparseArraysBase = "0d5efcca-f356-4864-8770-e1ed8d78f208"
 Suppressor = "fd094767-a336-5f1f-9728-57cf17d0bbfb"