Skip to content

Conversation

@mtfishman
Copy link
Member

@mtfishman mtfishman commented Feb 13, 2025

These weren't added as downstream tests before since they don't technically depend on SymmetrySectors.jl but SymmetrySectors.jl is used in their tests when constructing symmetric tensors.

@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.33%. Comparing base (5eeaf22) to head (d8850fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files          13       13           
  Lines         414      414           
=======================================
  Hits          345      345           
  Misses         69       69           
Flag Coverage Δ
docs 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman requested review from lkdvos and ogauthe February 13, 2025 21:07
@mtfishman
Copy link
Member Author

Some of the downstream tests are failing, but that should be fixed by ITensor/TypeParameterAccessors.jl#36 and ITensor/BlockSparseArrays.jl#48.

@ogauthe
Copy link
Collaborator

ogauthe commented Feb 13, 2025

I realized TensorAlgebra is still using a custom U1 in test/test_gradedunitrangesext_basics.jl. Maybe we should also switch to SymmetrySectors.U1 there and have SymmetrySectors as a test dependency for TensorAlgebra too?

@mtfishman
Copy link
Member Author

I realized TensorAlgebra is still using a custom U1 in test/test_gradedunitrangesext_basics.jl. Maybe we should also switch to SymmetrySectors.U1 there and have SymmetrySectors as a test dependency for TensorAlgebra too?

Makes sense.

@mtfishman mtfishman closed this Feb 14, 2025
@mtfishman mtfishman reopened this Feb 14, 2025
@mtfishman mtfishman merged commit 1d87606 into main Feb 14, 2025
25 of 28 checks passed
@mtfishman mtfishman deleted the integrationtet branch February 14, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants