Add trivial bipermutation interface to matricized factorizations and functions

Author: mtfishman

Project.toml

@@ -1,7 +1,7 @@
 name = "TensorAlgebra"
 uuid = "68bd88dc-f39d-4e12-b2ca-f046b68fcc6a"
 authors = ["ITensor developers <[email protected]> and contributors"]
-version = "0.5.1"
+version = "0.5.2"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

src/factorizations.jl

@@ -7,22 +7,30 @@ for f in (
     @eval begin
         function $f(
                 A::AbstractArray,
-                codomain_perm::Tuple{Vararg{Int}}, domain_perm::Tuple{Vararg{Int}};
+                codomain_length::Val, domain_length::Val;
                 kwargs...,
             )
             # tensor to matrix
-            A_mat = matricize(A, codomain_perm, domain_perm)
+            A_mat = matricize(A, codomain_length, domain_length)
 
             # factorization
             X, Y = MatrixAlgebra.$f(A_mat; kwargs...)
 
             # matrix to tensor
-            biperm = permmortar((codomain_perm, domain_perm))
+            biperm = blockedtrivialperm((codomain_length, domain_length))
             axes_codomain, axes_domain = blocks(axes(A)[biperm])
             axes_X = tuplemortar((axes_codomain, (axes(X, 2),)))
             axes_Y = tuplemortar(((axes(Y, 1),), axes_domain))
             return unmatricize(X, axes_X), unmatricize(Y, axes_Y)
         end
+        function $f(
+                A::AbstractArray,
+                codomain_perm::Tuple{Vararg{Int}}, domain_perm::Tuple{Vararg{Int}};
+                kwargs...,
+            )
+            A_perm = permuteblockeddims(A, codomain_perm, domain_perm)
+            return $f(A_perm, Val(length(codomain_perm)), Val(length(domain_perm)); kwargs...)
+        end
         function $f(A::AbstractArray, labels_A, labels_codomain, labels_domain; kwargs...)
             biperm = blockedperm_indexin(Tuple.((labels_A, labels_codomain, labels_domain))...)
             return $f(A, blocks(biperm)...; kwargs...)

src/matrixfunctions.jl

@@ -35,14 +35,22 @@ for f in MATRIX_FUNCTIONS
     @eval begin
         function $f(
                 a::AbstractArray,
-                codomain_perm::Tuple{Vararg{Int}}, domain_perm::Tuple{Vararg{Int}};
+                codomain_length::Val, domain_length::Val;
                 kwargs...,
             )
-            a_mat = matricize(a, codomain_perm, domain_perm)
+            a_mat = matricize(a, codomain_length, domain_length)
             fa_mat = Base.$f(a_mat; kwargs...)
-            biperm = permmortar((codomain_perm, domain_perm))
+            biperm = blockedtrivialperm((codomain_length, domain_length))
             return unmatricize(fa_mat, axes(a)[biperm])
         end
+        function $f(
+                a::AbstractArray,
+                codomain_perm::Tuple{Vararg{Int}}, domain_perm::Tuple{Vararg{Int}};
+                kwargs...,
+            )
+            a_perm = permuteblockeddims(a, codomain_perm, domain_perm)
+            return $f(a_perm, Val(length(codomain_perm)), Val(length(domain_perm)); kwargs...)
+        end
         function $f(a::AbstractArray, labels_a, labels_codomain, labels_domain; kwargs...)
             biperm = blockedperm_indexin(Tuple.((labels_a, labels_codomain, labels_domain))...)
             return $f(a, blocks(biperm)...; kwargs...)