copy kwarg

Author: ogauthe

src/contract/contract_matricize/contract.jl

@@ -35,11 +35,10 @@ function contract_inplace!(
 )
   biperm_dest = invbiperm(biperm_out, Val(first(blocklengths(biperm1))))
   check_input(contract, a_dest, biperm_dest, a1, biperm1, a2, biperm2)
-  a_dest_mat = matricize(a_dest, biperm_dest)
-  a1_mat = matricize(a1, biperm1)
-  a2_mat = matricize(a2, biperm2)
+  a_dest_mat = matricize(a_dest, biperm_dest; copy=false)
+  a1_mat = matricize(a1, biperm1; copy=false)
+  a2_mat = matricize(a2, biperm2; copy=false)
   mul!(a_dest_mat, a1_mat, a2_mat, α, β)
-  unmatricize!(a_dest, a_dest_mat, biperm_dest)  # TODO remove: need no copy in matricize
   return a_dest
 end
 

src/matricize.jl

@@ -45,20 +45,23 @@ end
 # matrix factorizations assume copy
 # maybe: copy=false kwarg
 
-function matricize(a::AbstractArray, biperm::AbstractBlockPermutation{2})
+function matricize(a::AbstractArray, biperm::AbstractBlockPermutation{2}; copy=false)
   ndims(a) == length(biperm) || throw(ArgumentError("Invalid bipermutation"))
-  return matricize(FusionStyle(a), a, biperm)
+  return matricize(FusionStyle(a), a, biperm; copy)
 end
 
 function matricize(
-  style::FusionStyle, a::AbstractArray, biperm::AbstractBlockPermutation{2}
+  style::FusionStyle, a::AbstractArray, biperm::AbstractBlockPermutation{2}; copy=false
 )
+  if istrivialperm(Tuple(biperm)) && !copy
+    return matricize(style, a, trivialperm(biperm))
+  end
   a_perm = permuteblockeddims(a, biperm)
   return matricize(style, a_perm, trivialperm(biperm))
 end
 
 function matricize(
-  style::FusionStyle, a::AbstractArray, biperm::BlockedTrivialPermutation{2}
+  style::FusionStyle, a::AbstractArray, biperm::BlockedTrivialPermutation{2}; copy=false
 )
   return throw(MethodError(matricize, Tuple{typeof(style),typeof(a),typeof(biperm)}))
 end
@@ -69,8 +72,8 @@ function matricize(::ReshapeFusion, a::AbstractArray, biperm::BlockedTrivialPerm
   return reshape(a, new_axes...)
 end
 
-function matricize(a::AbstractArray, permblock1::Tuple, permblock2::Tuple)
-  return matricize(a, blockedpermvcat(permblock1, permblock2; length=Val(ndims(a))))
+function matricize(a::AbstractArray, permblock1::Tuple, permblock2::Tuple; copy=false)
+  return matricize(a, blockedpermvcat(permblock1, permblock2; length=Val(ndims(a))); copy)
 end
 
 # ====================================  unmatricize  =======================================