Skip to content

Commit c468c4d

Browse files
committed
Fix method overwrite
1 parent 0822d37 commit c468c4d

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

src/MatrixAlgebra.jl

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,28 +75,29 @@ for (svd, svd_trunc, svd_full, svd_compact) in (
7575
(:svd, :svd_trunc, :svd_full, :svd_compact),
7676
(:svd!, :svd_trunc!, :svd_full!, :svd_compact!),
7777
)
78+
_svd = Symbol(:_, svd)
7879
@eval begin
7980
function $svd(
8081
A::AbstractMatrix;
81-
full::Union{Bool, Val{Bool}} = Val(false),
82+
full::Union{Bool, Val} = Val(false),
8283
trunc = nothing,
8384
kwargs...,
8485
)
85-
return _svd(full, trunc, A; kwargs...)
86+
return $_svd(full, trunc, A; kwargs...)
8687
end
87-
function _svd(full::Bool, trunc, A::AbstractMatrix; kwargs...)
88-
return _svd(Val(full), trunc, A; kwargs...)
88+
function $_svd(full::Bool, trunc, A::AbstractMatrix; kwargs...)
89+
return $_svd(Val(full), trunc, A; kwargs...)
8990
end
90-
function _svd(full::Val{false}, trunc::Nothing, A::AbstractMatrix; kwargs...)
91+
function $_svd(full::Val{false}, trunc::Nothing, A::AbstractMatrix; kwargs...)
9192
return $svd_compact(A; kwargs...)
9293
end
93-
function _svd(full::Val{false}, trunc, A::AbstractMatrix; kwargs...)
94+
function $_svd(full::Val{false}, trunc, A::AbstractMatrix; kwargs...)
9495
return $svd_trunc(A; trunc, kwargs...)
9596
end
96-
function _svd(full::Val{true}, trunc::Nothing, A::AbstractMatrix; kwargs...)
97+
function $_svd(full::Val{true}, trunc::Nothing, A::AbstractMatrix; kwargs...)
9798
return $svd_full(A; kwargs...)
9899
end
99-
function _svd(full::Val{true}, trunc, A::AbstractMatrix; kwargs...)
100+
function $_svd(full::Val{true}, trunc, A::AbstractMatrix; kwargs...)
100101
return throw(
101102
ArgumentError(
102103
"Specified both full and truncation, currently not supported"

0 commit comments

Comments
 (0)