-
Notifications
You must be signed in to change notification settings - Fork 2
more generic broadcast for AbstractBlockTuple
#46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 95.18% 95.43% +0.25%
==========================================
Files 14 14
Lines 415 438 +23
==========================================
+ Hits 395 418 +23
Misses 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Looks great, looks like a nice implementation of combining the block structures. Ready to merge? |
Not yet, I took a shortcut for the 2nd type parameter. I need to fix |
Base.Broadcast.axistype(::Base.OneTo, b::BlockedOneTo) = b
Base.Broadcast.axistype(b::BlockedOneTo, ::Base.OneTo, ) = b in |
I think this looks reasonable for now. Ready to merge? |
This PR generalizes broadcast for
AbstractBlockTuple
. It allows broadcast between anAbstractBlockTuple
andAbstractBlockTuple
with same total length but different blocklengthsTuple
with same lengthAbstractVector
with same length