Skip to content

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Apr 22, 2025

To-do:

  • Add tests.

@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.63%. Comparing base (f166200) to head (73ac13a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   94.41%   94.63%   +0.22%     
==========================================
  Files          14       14              
  Lines         412      429      +17     
==========================================
+ Hits          389      406      +17     
  Misses         23       23              
Flag Coverage Δ
docs 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman mtfishman requested a review from lkdvos April 22, 2025 23:41
@mtfishman
Copy link
Member Author

@lkdvos curious to hear your thoughts on this design. There are clearly many ways to numerically detect degenerate subspaces, the current design checks if neighboring values in the spectrum are close to each other up to the specified tolerances.

@mtfishman mtfishman closed this Apr 23, 2025
@mtfishman mtfishman reopened this Apr 23, 2025
Copy link
Contributor

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for some style things looks good to me!

@mtfishman mtfishman merged commit bb930c7 into main Apr 23, 2025
15 checks passed
@mtfishman mtfishman deleted the truncate_degenerate branch April 23, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants