-
Notifications
You must be signed in to change notification settings - Fork 2
Truncation strategy for degenerate subspaces #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 94.41% 94.63% +0.22%
==========================================
Files 14 14
Lines 412 429 +17
==========================================
+ Hits 389 406 +17
Misses 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@lkdvos curious to hear your thoughts on this design. There are clearly many ways to numerically detect degenerate subspaces, the current design checks if neighboring values in the spectrum are close to each other up to the specified tolerances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for some style things looks good to me!
To-do: