pokemon emerald - broken gfx when using cable cart

[ITotalJustice]

the cable does not fully extend to the top. looking at this video shows it fully extended.

the cable is an 4bpp affine object.

[ITotalJustice]

i fixed it. so the issue was to do with the wrap around. the formula for calculating the y position is correct, but i was using the wrong height value. i was using the non-scaled height value. as this object is affine2X (double size), the height should have been doubled.

notorious_beeg/src/core/ppu/render.cpp

Line 504 in 711951e

const auto sprite_y = obj.attr0.Y + height > 256 ? obj.attr0.Y - 256 : obj.attr0.Y;