Skip to content

Commit 4c5d73a

Browse files
AmosLewisIanNod
authored andcommitted
Fix export_atifcats usage in benchmark test (nod-ai#1285)
- Fix issue in 0418 llama nightly benchmark test https://github.com/nod-ai/shark-ai/actions/runs/14534130397/job/40779266661#step:7:1036 bring from nod-ai#1172 (review) - Xfail llama70B codegen issue in 0419 llama70b nightly benchmark test https://github.com/nod-ai/shark-ai/actions/runs/14548496681/job/40816909348#step:7:386534
1 parent ab9c76c commit 4c5d73a

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

sharktank/tests/models/llama/benchmark_amdgpu_test.py

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -378,12 +378,12 @@ def testBenchmark8B_fp8_attnf8_TP1_Non_Decomposed_Input_Len_2048(self):
378378
suffix=".txt", prefix=output_file_name
379379
)
380380
export_return_code = self.llama8b_fp8_attnf8_sdpa_artifacts.export_to_mlir(
381-
mlir_path=output_mlir,
382-
json_path=output_json,
381+
output_mlir=output_mlir,
382+
output_config=output_json,
383383
)
384384
self.llama8b_fp8_attnf8_sdpa_artifacts.compile_to_vmfb(
385-
mlir_path=str(output_mlir),
386-
vmfb_path=output_vmfb,
385+
output_mlir=str(output_mlir),
386+
output_vmfb=output_vmfb,
387387
hal_dump_path=output_file_name,
388388
cwd=self.repo_root,
389389
args=self.compile_args,
@@ -423,12 +423,12 @@ def testBenchmark8B_fp8_attnf8_TP1_Non_Decomposed_Input_Len_128(self):
423423
suffix=".txt", prefix=output_file_name
424424
)
425425
export_return_code = self.llama8b_fp8_attnf8_sdpa_artifacts.export_to_mlir(
426-
mlir_path=output_mlir,
427-
json_path=output_json,
426+
output_mlir=output_mlir,
427+
output_config=output_json,
428428
)
429429
self.llama8b_fp8_attnf8_sdpa_artifacts.compile_to_vmfb(
430-
mlir_path=str(output_mlir),
431-
vmfb_path=output_vmfb,
430+
output_mlir=str(output_mlir),
431+
output_vmfb=output_vmfb,
432432
hal_dump_path=output_file_name,
433433
cwd=self.repo_root,
434434
args=self.compile_args,
@@ -666,7 +666,9 @@ def testBenchmark70B_f16_TP1_Non_Decomposed_Input_Len_2048(self):
666666
)
667667

668668
@pytest.mark.xfail(
669-
reason="Benchmarking Error", strict=True, raises=IreeBenchmarkException
669+
run=False,
670+
reason="https://github.com/iree-org/iree/issues/20581",
671+
raises=IreeCompileException,
670672
)
671673
def testBenchmark70B_f16_TP8_Non_Decomposed_Input_Len_128(self):
672674
output_file_name = self.dir_path_70b / "f16_torch_128_tp8"
@@ -716,7 +718,9 @@ def testBenchmark70B_f16_TP8_Non_Decomposed_Input_Len_128(self):
716718
)
717719

718720
@pytest.mark.xfail(
719-
reason="Benchmarking Error", strict=True, raises=IreeBenchmarkException
721+
run=False,
722+
reason="https://github.com/iree-org/iree/issues/20581",
723+
raises=IreeCompileException,
720724
)
721725
def testBenchmark70B_f16_TP8_Non_Decomposed_Input_Len_2048(self):
722726
output_file_name = self.dir_path_70b / "f16_torch_2048_tp8"

0 commit comments

Comments
 (0)