handling RPCs where batch requests are not allowed at all by executing them as single requests.

Author: simone1999

IceCreamSwapWeb3/BatchRetryMiddleware.py

@@ -10,6 +10,10 @@ class BatchRetryMiddleware(Web3Middleware):
 
     def wrap_make_batch_request(self, make_batch_request):
         def middleware(requests_info) -> list:
+            if self._w3.rpc_batch_max_size == 0:
+                # RPC does not support batch requests at all, splitting batch into single, non batch, requests
+                return [make_batch_request.__self__.make_request(method, params) for method, params in requests_info]
+
             if len(requests_info) > self._w3.rpc_batch_max_size:
                 response = []
                 for start in range(0, len(requests_info), self._w3.rpc_batch_max_size):

IceCreamSwapWeb3/Web3Advanced.py

@@ -92,7 +92,7 @@ def _construct_provider(node_url):
     def start_multicall(self) -> MultiCall:
         return MultiCall(w3=self)
 
-    def _find_max_filter_range(self):
+    def _find_max_filter_range(self) -> int:
         current_block = self.eth.block_number
         for filter_range in self.FILTER_RANGES_TO_TRY:
             try:
@@ -110,7 +110,7 @@ def _find_max_filter_range(self):
         print(f"Can not use eth_getLogs with RPC {self.node_url}")
         return 0
 
-    def _find_max_batch_size(self):
+    def _find_max_batch_size(self) -> int:
         for batch_size in self.BATCH_SIZES_TO_TRY:
             try:
                 with self.batch_requests() as batch:
@@ -121,7 +121,8 @@ def _find_max_batch_size(self):
                 return batch_size
             except Exception:
                 pass
-        raise
+        print(f"Can not use batch requests with RPC {self.node_url}")
+        return 0
 
     def _check_revert_reason_available(self):
         with files("IceCreamSwapWeb3").joinpath("./abi/RevertTester.abi").open('r') as f: